Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONAR: Merge this if statement with the enclosing one. #8765

Merged
merged 3 commits into from Dec 7, 2018
Merged

SONAR: Merge this if statement with the enclosing one. #8765

merged 3 commits into from Dec 7, 2018

Conversation

slawekk87
Copy link
Contributor

Description

Testing

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

@slawekk87 slawekk87 added the ✔ finished This pull request has been finished. label Dec 4, 2018
@slawekk87 slawekk87 added this to the YetiForce 5.0 milestone Dec 4, 2018
mariuszkrzaczkowski
mariuszkrzaczkowski requested changes Dec 7, 2018
View reviewed changes
modules/Users/actions/Save.php Outdated Show resolved Hide resolved
modules/Vtiger/models/Record.php Outdated Show resolved Hide resolved
@mariuszkrzaczkowski mariuszkrzaczkowski added 🔧 AmendmentsRequired This pull request requires some amendments in order to be merged. and removed ✔ finished This pull request has been finished. labels Dec 7, 2018
@slawekk87 slawekk87 added ✔ finished This pull request has been finished. and removed 🔧 AmendmentsRequired This pull request requires some amendments in order to be merged. labels Dec 7, 2018
@rskrzypczak @slawekk87
Update modules/Users/models/Module.php
2bd8441 
Co-Authored-By: slawekk87 <slawekk87@gmail.com>
@rskrzypczak rskrzypczak merged commit 5f6a68d into YetiForceCompany:developer Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariuszkrzaczkowski mariuszkrzaczkowski mariuszkrzaczkowski approved these changes

@rskrzypczak rskrzypczak rskrzypczak approved these changes

Assignees

@mariuszkrzaczkowski mariuszkrzaczkowski

@rskrzypczak rskrzypczak

Labels
✔ finished This pull request has been finished.
Projects
YetiForceCRM
Awaiting triage
Milestone
YetiForce 5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slawekk87 @mariuszkrzaczkowski @rskrzypczak