Skip to content
This repository has been archived by the owner on Jul 29, 2023. It is now read-only.

(Re-)setup indent guide lines on for missing autocommands #299

Closed

Conversation

ohcibi
Copy link

@ohcibi ohcibi commented Apr 2, 2020

The setup was not redone on BufEnter and TerminalOpen|TermOpen which
made the plugin ignore the indentLIne_*Exclude and probably also the
indentLine_FileType configuration option in some situations.
Possibly a fix for #297

The setup was not redone on `BufEnter` and `TerminalOpen|TermOpen` which
made the plugin ignore the indentLIne_*Exclude and probably also the
indentLine_FileType configuration option in some situations.
Possibly a fix for Yggdroot#297
Copy link
Contributor

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem where it ignores terminal buffers! Thanks! Would be great to have this merged

@Yggdroot
Copy link
Owner

BufEnter is almost a duplicate of BufWinEnter, the function will be called twice every time a buffer is entered. I don't want to have the slowdown.

@ohcibi
Copy link
Author

ohcibi commented Apr 12, 2020

@Yggdroot the exclude filetypes/buftypes feature is broken without it. Do you have another idea? Why is BufWinEnter needed? We could remove that since instead.

Sent with GitHawk

@Yggdroot
Copy link
Owner

BufWinEnter is necessary to support modeline.

@ohcibi
Copy link
Author

ohcibi commented Apr 12, 2020

Then we need to split up that functionality. BufWinEnter is not called in every necessary situation. The documentation clearly recommends BufEnter for filetype specific settings. Since this is about excluding file types it should be called there.

Sent with GitHawk

@Yggdroot
Copy link
Owner

So we can save the &shiftwidth and &tabstop to buffer-local variables when BufWinEnter is triggered. Use the variables when BufEnter is triggered.

@Yggdroot Yggdroot closed this Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants