Fill up C++ sections #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
reviewed
Jan 17, 2024
A72-open-telemetry-tracing.md
Outdated
| } | ||
| // If `SetTracerProvider()` is not called, no traces are collected. | ||
| OpenTelemetryPluginBuilder& SetTracerProvider( | ||
| std::shared_ptr<opentelemetry::metrics::SetTracerProvider> |
There was a problem hiding this comment.
is this opentelemetry::metrics::SetTracerProvider correct?
A72-open-telemetry-tracing.md
Outdated
| std::shared_ptr<opentelemetry::metrics::SetTracerProvider> | ||
| tracer_provider); | ||
| // Set one or multiple text map propagators for span context propagation, e.g. | ||
| // GrpcTraceBinPropagator or community standard ones like W3C, etc. |
There was a problem hiding this comment.
not your fault but the GrpcTraceBinPropagator should be GrpcTraceBinTextMapPropagator to match elsewhere
YifeiZhuang
reviewed
Jan 17, 2024
There was a problem hiding this comment.
LGTM! Only minor comments. Feel free to merge after you resolve them.
(I also verified that the binary to spanContext converter is correct.
This is what java is using in open census and otel will have similar, they are equivalent to your's.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.