RedundantPropertyInitializationCheck

YiiRocks · Dec 19, 2020 · 5004b94 · 5004b94
1 parent f96808d
commit 5004b94
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/Icon.php b/src/Icon.php
@@ -35,8 +35,8 @@ class Icon implements IconInterface
      */
     private string $name;
 
-    /** @var string Sets a title to the SVG output */
-    private string $title;
+    /** @var null|string Sets a title to the SVG output */
+    private ?string $title;
 
     /**
      * @var int The width of the icon. This will dismiss the automatic height
@@ -45,6 +45,11 @@ class Icon implements IconInterface
      */
     private int $width;
 
+    public function __construct()
+    {
+        $this->title = null;
+    }
+
     /**
      * @see $icon
      * @param string $key
@@ -61,12 +66,7 @@ public function get(string $key)
      */
     public function getTitle(): string
     {
-        if (isset($this->title)) {
-            return $this->title;
-        }
-
-        $name = basename($this->name ?? '', '.svg');
-        return $name;
+        return $this->title ?? basename($this->name, '.svg');
     }
 
     public function setClass(string $value): void