Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the cache test case #59

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Improve the cache test case #59

merged 3 commits into from
Oct 15, 2020

Conversation

yi-Xu-0100
Copy link
Contributor

@yi-Xu-0100 yi-Xu-0100 commented Oct 14, 2020

Use the Linux-yikun-repos-cache-{times} as key, and Linux-yikun-repos-cache- as restore_key to make sure the cache would be refreshed at every PR.

close #58

.github/workflows/verify-on-ubuntu-user-cache.yml Outdated Show resolved Hide resolved
.github/workflows/verify-on-ubuntu-user-cache.yml Outdated Show resolved Hide resolved
无需指定 token,默认提供。
Copy link
Contributor Author

@yi-Xu-0100 yi-Xu-0100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

在 secret 中设置 ACTIONS_STEP_DEBUG 的内容为 true ,然后重新运行一下看看呢?

image

应该会给出一下 action 的 debug 信息,大部分的 secret 信息会被默认打码的

.github/workflows/verify-on-ubuntu-user-cache.yml Outdated Show resolved Hide resolved
@yi-Xu-0100 yi-Xu-0100 requested a review from Yikun October 15, 2020 09:20
修复获取时间错误
@yi-Xu-0100
Copy link
Contributor Author

script 默认的 return 被设置的名字是 result ,我弄错了。已修改

@Yikun Yikun changed the title update cache usage Improve the cache test case Oct 15, 2020
Copy link
Owner

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#60

好了,看了下key正常了,我合入了

@Yikun Yikun merged commit 7681189 into Yikun:master Oct 15, 2020
@yi-Xu-0100
Copy link
Contributor Author

@Yikun 我注意到一个问题,由于原先的测试问题,造成 Linux-yikun-repos-cache- 被设置为 key 值, 且能够触发并被成功 cached,而 restore_key 匹配前缀的话,则必然会触发这个 Linux-yikun-repos-cache- 的 key 值,可能需要修改关键词,重建一下……

比如 :

        key: ${{ runner.os }}-yikun-hub-cache-${{ steps.info.outputs.result }}
        restore-keys: ${{ runner.os }}-yikun-hub-cache

非常抱歉,我的失误造成这样的问题……😭

@Yikun
Copy link
Owner

Yikun commented Oct 15, 2020

@yi-Xu-0100 奥,好,就改成这个。cache这个反正确实挺烦人的。

那改后,就是每次会保存cache${{ runner.os }}-yikun-hub-cache-${{ steps.info.outputs.result }},然后回从${{ runner.os }}-yikun-hub-cache匹配回复最近的?对吧

@Yikun
Copy link
Owner

Yikun commented Oct 15, 2020

#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache 使用更新
2 participants