Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arch] 自研代码与上游criticality_score代码分离 #1

Closed
Yikun opened this issue Jan 7, 2021 · 3 comments · Fixed by #9
Closed

[arch] 自研代码与上游criticality_score代码分离 #1

Yikun opened this issue Jan 7, 2021 · 3 comments · Fixed by #9
Assignees
@Yikun

Comments

@Yikun
Copy link
Owner

Yikun commented Jan 7, 2021

原repo里面代码相对独立，集中在criticality_score的目录，为了后续演进，建议把批量查询的接口和原接口进行分离。

备选方案：
方案1. 把criticality_score作为依赖，批量和参数独立一个项目演进，完全解耦
方案2. 不在criticality_score中侵入修改，把批量的接口单独搞个文件，至少确保上游的代码可以及时同步进来
@Yikun Yikun changed the title 自研代码与上游criticality_score代码分离 [arch] 自研代码与上游criticality_score代码分离 Jan 7, 2021
@zhaorenhai
Copy link
Contributor

之所以把包名也改了，就是为了避免有人在同一个机器上装了原工具，又装了这个。
主要是为了避免冲突

@Yikun
Copy link
Owner Author

Yikun commented Jan 7, 2021 •
edited

https://github.com/Yikun/reposcore

批量的解耦，方案1的实现

@Yikun Yikun self-assigned this Jan 7, 2021
@Yikun Yikun transferred this issue from another repository Jan 8, 2021
@Yikun Yikun mentioned this issue Jan 8, 2021
Merged
@Yikun
Copy link
Owner Author

Yikun commented Jan 8, 2021 •
edited

已经将v1版本移动到https://github.com/kunpengcompute/reposcore_deprecated ，然后所有的issue已经transfer完了。

等#9 合入后，干掉原版本的repo。

Yikun added a commit that referenced this issue Jan 8, 2021
@Yikun
Initiail commit for Repo Score v2
586ff2a 
The Repo Score v1 is forked from criticality_score and had much
not graceful modification on upstream code, after the discussion[1],
we decided to decouple the dependency of criticality_score.

So in this patch, we keep the v1 code and doc unchanged, only move
the criticality_score into requirements, set the setup version to
2.0.0 to avoid the pypi reupload problem[2].

[1] #1
[2] pypa/packaging-problems#74

Close: #1
Yikun added a commit that referenced this issue Jan 8, 2021
@Yikun
Initiail commit for Repo Score v1.1.0
2239a93 
The Repo Score v1 is forked from criticality_score and had much
not graceful modification on upstream code, after the discussion[1],
we decided to decouple the dependency of criticality_score.

So in this patch, we keep the v1 code and doc unchanged, only move
the criticality_score into requirements, set the setup version to
1.1.0.

[1] #1

Close: #1
ZhengZhenyu added a commit that referenced this issue Jan 18, 2021
@ZhengZhenyu
Merge pull request #1 from ZhengZhenyu/config-description
aca4f81 
Add description about config parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yikun Yikun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initiail commit for Repo Score v2 Yikun/reposcore
2 participants
@Yikun @zhaorenhai