Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes #2

Merged
merged 4 commits into from
Apr 23, 2024
Merged

small fixes #2

merged 4 commits into from
Apr 23, 2024

Conversation

xesdoog
Copy link
Contributor

@xesdoog xesdoog commented Mar 24, 2024

Changelog window:

  • The changelog window dimensions are smaller than the content inside it. With its previous config flags, it was impossible to read the rest of the text and most importantly, it was impossible to close it so you had to reload Harmless's script. I've added a check to the window flags that enables a (x) close button in the title bar so you can close it like a normal window and also enabled mouse scrolling. The scroll bar is currently enabled too because my mouse wheel is broken 馃槶 and no I'm not buying a new one because I play competitive For Honor and that game cost me like 30 mice and 12 keyboards over a span of 6 years. #!*@ For Honor! 馃槨
  • Replaced an unsupported character (馃帀) in the changelog text.
  • Disabled the [close] button at the bottom of the window but you can re-enable it if you want.

Self Options > Ragdoll:

  • The params for both ragdoll loop and the ragdoll once button were set to never allow the player to get back up so once you use either one of the two options, you'll be stuck in ragdoll. I've adjusted them so the player automatically gets up after a few seconds.

HS Settings > HUD:

  • expandedRadarCB: Moved the execution under the checkbox and removed the while loop because it was causing the script to immediately hide the minimap in GTA online whenever it runs. we don't need to loop it because it's basically an on/off switch depending on the state of the checkbox.
  • I think the reason why it doesn't work online is that it needs a check before it which is CFX.IS_BIGMAP_ACTIVE() but we can't run CFX natives. I'm not entirely sure though so this might need further testing or just leave it as is. It works fine in SP and it's not really a useful feature in online.

* Changelog window:
- The changelog window dimensions are smaller than the content inside it. With its previous config flags, it was impossible to read the rest of the text and most importantly, it was impossible to close it so you had to reload Harmless's script. I've added a check to the window flags that enables a (x) close button in the title bar so you can close it like a normal window and also enabled mouse scrolling. The scroll bar is currently enabled too because my mouse wheel is broken 馃槶 and no I'm not buying a new one because I play competitive For Honor and that game cost me like 30 mice and 12 keyboards over a span of 6 years. #!*@ For Honor! 馃槨
- Replaced an unsupported character (馃帀) in the changelog text.
- Disabled the [close] button at the bottom of the window but you can re-enable it if you want.

* Self Options > Ragdoll:
- The params for both ragdoll loop and the ragdoll once button were set to never allow the player to get back up so once you use either one of the two options, you'll be stuck in ragdoll.

*HS Settings > HUD:
- expandedRadarCB: Moved the execution under the checkbox and removed the wile loop because it was causing the script to immediately hide the minimap in GTA online whenever it runs. we don't need to loop it because it's basically an on/off switch depending on the state of the checkbox.
- I think the reason why it doesn't work online is that it needs a check before it which is CFX.IS_BIGMAP_ACTIVE() but we can't run CFX natives. I'm not entirely sure though so this might need further testing or just leave it as is. It works fine in SP and it's not really a useful feature in online.
@Harmless05
Copy link
Collaborator

Harmless05 commented Mar 24, 2024

Well done. Yes, the Ragdoll and Radar bugs were there and I didn't find a fix for them when I was testing.

I'll look at them early next week, as I don't have much time at the moment.

Edit: I've thought about removing the changelog from the script. (I've already commented it out of my version)

@Harmless05 Harmless05 self-assigned this Mar 24, 2024
@Harmless05
Copy link
Collaborator

Harmless05 commented Mar 25, 2024

Made some minor tweaks and fixed a small bug with "Walk on air" where the object was created before the model was loaded on the first execution.

Edit: I'm quite new to PR's, so bear with me as I try to figure it all out :D

@xesdoog
Copy link
Contributor Author

xesdoog commented Mar 26, 2024

Made some minor tweaks and fixed a small bug with "Walk on air" where the object was created before the model was loaded on the first execution.

Edit: I'm quite new to PR's, so bear with me as I try to figure it all out :D

I've read through YimMenu's no clip and wanted to turn this into that but then I got distracted with something else. If you want to, we can work together on it but I don't think it's a good idea having the same option from the menu in a Lua. Walk on air is different and imo it should stay different but I tried figuring out a way to make it smoother other than using _NO_OFFSET with no luck

@Harmless05
Copy link
Collaborator

Yeah, I don't think that's a good idea. I try not to do things that already exist in the menu. Walk on air was a "remaster" of another gone menu.
I also wanted to make the walk on air smoother when I was making it, hence the odd sleep times and other things, but I couldn't make it look or work any better.

@Harmless05
Copy link
Collaborator

Included a fix for player regeneration (health & armour), where if the player was dead, it would continue to add unnecessary armour and health. faee153

@Harmless05 Harmless05 merged commit 266ac0a into YimMenu-Lua:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants