Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 1.66 #929

Merged
merged 24 commits into from Feb 3, 2023
Merged

Update for 1.66 #929

merged 24 commits into from Feb 3, 2023

Conversation

Yimura
Copy link
Member

@Yimura Yimura commented Feb 1, 2023

Closes #927

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Download the artifacts for this pull request:

@Yimura
Copy link
Member Author

Yimura commented Feb 1, 2023

YimMenu can load in offline from this point, don't even try loading online you'll crash 100%.

@Rimmuru
Copy link
Contributor

Rimmuru commented Feb 2, 2023

updated your todo hashes

Spectate = -2029707091
MCTeleport = 891653640
TSECommand = -1428749433
TSECommandRotateCam = 448051697
NotificationMoneyBanked = 276906331
NotificationMoneyRemoved = 853249803
NotificationMoneyStolen = 82080686

@Primexz
Copy link
Contributor

Primexz commented Feb 2, 2023

updated your todo hashes

Spectate = -2029707091 MCTeleport = 891653640 TSECommand = -1428749433 TSECommandRotateCam = 448051697 NotificationMoneyBanked = 276906331 NotificationMoneyRemoved = 853249803 NotificationMoneyStolen = 82080686

seems to be fine, checked.

@TheGreenBandit
Copy link
Contributor

Some natives were also changed ex graphics

@yasmasdas
Copy link
Contributor

Some globals and structs also changed

@SkiddyToast
Copy link
Contributor

Some globals and structs also changed

Which globals have changed?

@yasmasdas
Copy link
Contributor

I'm not fully aware but I know some in freemode.c did.

@Primexz
Copy link
Contributor

Primexz commented Feb 2, 2023

Some globals and structs also changed

Which globals have changed?

image
image
image

There are some more.

@TheGreenBandit
Copy link
Contributor

How do u know what each does though?

@Primexz
Copy link
Contributor

Primexz commented Feb 2, 2023

How do u know what each does though?

I can't know that, as of now I'm just comparing my last commit with the one from the last update. :=)

@SkiddyToast
Copy link
Contributor

There are some more.

Do you happen to know where the new ones were added in the middle?

@Primexz
Copy link
Contributor

Primexz commented Feb 2, 2023

There are some more.

Do you happen to know where the new ones were added in the middle?

Nope, as described above I am currently still comparing the diffs. Let's see what I still get out

@Primexz
Copy link
Contributor

Primexz commented Feb 2, 2023

freemode.patch
The full patch from the freemode script.
You can open the file in VS Code to see exactly what Rockstar has changed.
Important: Only Global updates are included in the patch.

@SkiddyToast
Copy link
Contributor

SkiddyToast commented Feb 2, 2023

I've narrowed it down between these two globals:

Global_2672505 is the same
Global_2680247 vs Global_2680249

@TheGreenBandit
Copy link
Contributor

Why did they skip game version 16.65 and go immediately to 16.66? One of the devs forget what version it was on?

@SkiddyToast
Copy link
Contributor

Why did they skip game version 16.65 and go immediately to 16.66? One of the devs forget what version it was on?

They didn't. 1.65 was a gen 9 only update. You can find it Here.

@TheGreenBandit
Copy link
Contributor

TheGreenBandit commented Feb 3, 2023

They didn't. 1.65 was a gen 9 only update.

Ah, that sucks. They shouldve at least pushed content for us pc players, and maybe some for old gen

@Primexz
Copy link
Contributor

Primexz commented Feb 3, 2023

I have now tested the branch for some time.
Except for some features everything seems to run stable

@TheGreenBandit
Copy link
Contributor

TheGreenBandit commented Feb 3, 2023

Ip, name, rid spoofing have apparently been patched rip, appears you can still locally spoof your name, rid, ip. But the only one worth keeping locally would be name

@Yimura Yimura marked this pull request as ready for review February 3, 2023 20:50
@Yimura
Copy link
Member Author

Yimura commented Feb 3, 2023

List of things that are broken:

  • Off Radar Global
  • Player Database (because RID's aren't in the rage::rlGamerInfo class anymore)
  • Spoofing of values in the send_net_info_to_lobby hook

There are probably many more things broken but at the least menu is usable now.

@Primexz
Copy link
Contributor

Primexz commented Feb 3, 2023

List of things that are broken:

  • Off Radar Global
  • Player Database (because RID's aren't in the rage::rlGamerInfo class anymore)
  • Spoofing of values in the send_net_info_to_lobby hook

There are probably many more things broken but at the least menu is usable now.

updated off radar, hope its ok that this is not an pr :)

*script_global(2672505).at(57).as<int*>() = NETWORK::GET_NETWORK_TIME() + 1;

@Yimura
Copy link
Member Author

Yimura commented Feb 3, 2023

updated off radar, hope its ok that this is not an pr :)

*script_global(2672505).at(57).as<int*>() = NETWORK::GET_NETWORK_TIME() + 1;

Yeah that's fine, if it's something small I prefer it be contributed like this.

Edit:
I removed all send_net_info_to_lobby hook related stuff for now, we can always revert it later if we find a way to fix that (although I doubt it'll be easy).

@Yimura
Copy link
Member Author

Yimura commented Feb 3, 2023

Merging this PR as-is, we can fix other features later on.

@Yimura Yimura merged commit 5c01d39 into master Feb 3, 2023
@Yimura Yimura deleted the 1.66 branch February 3, 2023 23:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game has been updated!
7 participants