New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lrc.format generating corrupt result #3

Merged

Yivan000 merged 1 commit into Yivan000:master from alexmercerind:patch-1

Sep 13, 2022

Contributor

alexmercerind commented Sep 12, 2022

Hi! First of all, thanks for the awesome package.

The Lrc.format methods seems to result in invalid .lrc.

The last timestamp element contains hundredths of a second & not milliseconds.
A period (.) is used to separate it, instead of a colon (:).

See: https://en.wikipedia.org/wiki/LRC_(file_format)

This resulted in Lrc.isValid to return false on the text generated by package itself.

Lastly, thanks again. Have a great day!


          fix: Lrc.format generating corrupt result

e99e906

Owner

Yivan000 commented Sep 13, 2022

Oh wow, thanks for the PR!

Yivan000 merged commit 1e77f2c into Yivan000:master

alexmercerind deleted the patch-1 branch

October 13, 2022 04:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment