Fixed hundreds formatted as milliseconds #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The lines "milliseconds: int.parse(i.substring(7, 9))" treated the hundred as milliseconds. Now they are fixed. - Refactored a few lines to make it less verbose.
|
Thank you for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lines
milliseconds: int.parse(i.substring(7, 9))considered the hundred as milliseconds. This problem could be easily detected when parsing LRC objects containing lyrics with set milliseconds, formatting them, and then comparing them to the output result. The hundreds are divided by 10 each time. Even the hundreds part usually aren't a big deal, this is not good for consistency. Now they are fixed.Refactored a few lines to make it less verbose.