Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

Alpine runtime container #3

Merged
merged 2 commits into from May 15, 2019
Merged

Conversation

AriPaaWun
Copy link
Contributor

Use Alpine (openjdk:8-jdk-alpine) as build platform
Use Alpine (openjdk:8-jre-alpine) as runtime

Had to explicitly ignore warnings when building nginx-clojure.

I have no idea if --no-cache has any effect on update&upgrade.

I'm released this as 1.12.2-0.4.5-2.1, 1.12.2-0.4.5-alpine and latest. It can be a breaking change to many things, but as far as I know, at the moment we are the only one using this. Version 1.12.2-0.4.5 will stay as it is until the heat death of the universe. Docker Hub

@AriPaaWun AriPaaWun requested a review from pvalkone May 15, 2019 09:48
@pvalkone
Copy link

I have no idea if --no-cache has any effect on update&upgrade.

The --no-cache option is exactly what we want, since we don't want to leave the package cache behind after we're finished installing packages.

As of Alpine Linux 3.3 there exists a new --no-cache option for apk. It allows users to install packages with an index that is updated and used on-the-fly and not cached locally [...] This avoids the need to use --update and remove /var/cache/apk/* when done installing packages.

https://github.com/gliderlabs/docker-alpine/blob/master/docs/usage.md#disabling-cache

Dockerfile Outdated
zlib1g-dev
RUN apk update && \
apk upgrade && \
apk add \
Copy link

@pvalkone pvalkone May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the --no-cache option to the update, upgrade and add commands.
See: https://github.com/gliderlabs/docker-alpine/blob/master/docs/usage.md#disabling-cache

@AriPaaWun AriPaaWun force-pushed the feature/alpine-runtime-container branch from b0c90d9 to b1d2c1f Compare May 15, 2019 10:16
@AriPaaWun AriPaaWun requested a review from pvalkone May 15, 2019 10:17
@AriPaaWun AriPaaWun force-pushed the feature/alpine-runtime-container branch from b1d2c1f to 9b38822 Compare May 15, 2019 11:21
@AriPaaWun AriPaaWun force-pushed the feature/alpine-runtime-container branch from 9b38822 to c16f2d2 Compare May 15, 2019 11:39
@AriPaaWun AriPaaWun merged commit c16f2d2 into master May 15, 2019
@AriPaaWun AriPaaWun deleted the feature/alpine-runtime-container branch May 15, 2019 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants