"RDP Connect" is not being translated

[supra36]

Describe the bug
"RDP Connect" string is not being translated altough its translation is present in different locales

To Reproduce
Steps to reproduce the behavior:

1. Change language to any language preferred
2. Go to any machine
3. "RDP Connect" is not translated

Expected behavior
Should translate "RDP Connect" to desired language.

Screenshots

[si458]

I think I know what this is.
Last month I changed the button to show RDP Connect (1234) if u set a different RDP port, so I have a feeling this is why its not being translated!
Will check later on

[si458]

ok all fixed for you!
sorry about this, it was what i throught it was.
ive moved the rdp custom port to the right hand side now, so the buttons back to its normal translate!
you can patch it yourself by changing the few lines in default.handlebars - bb93c11

EDIT: you can ignore lines 784/785, that was a formatting error on my side!
only lines 687 and 8993/8993-8997 need to be applied!

[nicrame]

For me the patch (well, i downloaded whole new file and replaced old one) didn't resolve problem.

[si458]

to fix above

1. copy master version of default.handlebars to `node_modules/meshcentral/views/
2. run node translate.js extractall from inside node_modules/meshcentral/translations
   (this step extracts the english handlebar files for all new strings and locations as they can change
3. run node translate.js translateall from inside node_modules/meshcentral/translations
   (this step will translate the english handlebar files into all the languages