Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat and Notify buttons show even tho not ticked in permissions #5858

Closed
exander77 opened this issue Feb 26, 2024 · 9 comments
Closed

Chat and Notify buttons show even tho not ticked in permissions #5858

exander77 opened this issue Feb 26, 2024 · 9 comments
Labels

Comments

@exander77
Copy link

This is more of a question, maybe? Maybe a bug.

If I create a user View Only and doesn't and doesn't tick Chat and Notifications, the user still has Chat and Notifications buttons visible. When I check it, it doesn't seem to change anything. Shouldn't it be No Chat and Notifications if it is enabled by default?

@exander77 exander77 added the bug label Feb 26, 2024
@si458
Copy link
Collaborator

si458 commented Feb 29, 2024

where are you seeing the options for 'View Only' and 'Chat and Notifications' ?

@si458 si458 added question and removed bug labels Feb 29, 2024
@exander77
Copy link
Author

@si458 User permissions to device or device group.

@si458
Copy link
Collaborator

si458 commented Feb 29, 2024

ah right ok yeh got you!
image
and you mean the 'Message' and 'Chat' buttons are still shown on the General tab of the device?
image

@si458 si458 changed the title Chat and Notifications option Chat and Notify buttons show even tho not ticked in permissions Feb 29, 2024
@si458 si458 added bug and removed question labels Feb 29, 2024
@exander77
Copy link
Author

Yes. That's it.

@si458
Copy link
Collaborator

si458 commented Feb 29, 2024

hmmm ok i think the is a bug, will dig into the permission tomorrow and see if i can follow them

if (Q('p20remotecontrol').checked == true) meshadmin += 8;
if (Q('p20chatnotify').checked == true) meshadmin += 16384;

...

if ((meshrights & 8) && ((connectivity & 1) || ((node.pmt == 1) && ((features2 & 2) != 0)))) { x += '<input type=button value="' + "Message" + '" title="' + "Display a text message on the remote device" + '" onclick=deviceMessageFunction() />';  }
if ((meshrights & 8) && (connectivity & 1) || ((node.pmt == 1) && ((features2 & 2) != 0))) { x += '<input type=button value="' + "Chat" + '" title="' + "Open chat window to this computer" + '" onclick=deviceChat(event) />'; }                    

@exander77
Copy link
Author

Is it related to this? #5857
Or is this a separate issue?

@exander77
Copy link
Author

I looks like a frontend code? But the issue is surely in backend as well as these buttons work (it's not just that they are there). The other issue is also a backend issue, when I display the button, it still doesn't work.

@si458
Copy link
Collaborator

si458 commented Feb 29, 2024

ive looked into it and a fix is incoming for the displaying of the buttons/icons

basically you cant use the chat/notify features WITHOUT having remote control ticked,
this is because the meshcentral needs to connect/access to the persons desktop to open up there web browser

BUT you can just tick 'no desktop/no files/no terminal' and the person wont have control of the remote device

si458 added a commit that referenced this issue Feb 29, 2024
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Feb 29, 2024

commit here with the display fix for you! 3e23741 👍

@si458 si458 closed this as completed Feb 29, 2024
wdlut pushed a commit to wdlut/MeshCentral that referenced this issue Mar 19, 2024
Signed-off-by: si458 <simonsmith5521@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants