-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docker environment #4310
Conversation
sschoen
commented
Jul 23, 2022
- Changed base image to alpine:latest (reduces the image size by ~40MB)
- Added CONFIG_FILE environment variable to optionally specify a different configuration-file
- Added SESSION_KEY environment variable for initial configuration
- Added optional build argument PREINSTALL_LIBS to install the following npm packages into the image:
- ssh2
- saslprep
- semver
- nodemailer
- image-size
- wildleek@2.0.0
- otplib@10.2.3
…ifferent config.json file
# cleanup | ||
RUN rm -rf /opt/meshcentral/meshcentral/docker | ||
RUN rm -rf /opt/meshcentral/meshcentral/node_modules | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also remove the docs folder as it only contains the md files and powerpoint files
EDIT: ignore me, one of those thick days im having
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs/ folder is in the .dockerignore file, it should not be copied at all...
EDIT: ignore me, im having a brain fart of a day, forgot to change your branch to |
EDIT: @sschoen please ignore me, |
LGTM |
@sschoen @Ylianst the automated docker builds worked perfectly! |
@si458 we should include the mongodb-tools and libs, even with that the image is still smaller than the node:current-alpine version and the server starts much faster... |
OK brilliant! |