fix mobile terminal not showing enter key for Android soft keyboard for sharing-moblile.handlebars #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use the soft keyboard had no enter key. IPhones seem to have the default imput mode "text". For Android I added the attribute imputmode="text" and got also the enter key on the soft keyboard.
Signed-off-by: Simon Smith <simonsmith5521@gmail.com>
|
thanks! just learnt how to edit peoples PR requests haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the same line as in pull request #5686 in sharing-mobile.handlebars and also changed it to make the fix complete.
Thank's for merging.