Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'deprecated' warnings in gh-workflows #5720

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Conversation

sschoen
Copy link
Contributor

@sschoen sschoen commented Jan 21, 2024

No description provided.

@si458
Copy link
Collaborator

si458 commented Jan 21, 2024

I have been meaning to update the github actions, thanks, but are you sure the release is going to work? As u have removed the my_token environment variable?

@sschoen
Copy link
Contributor Author

sschoen commented Jan 21, 2024

github-action-npm-release uses the GITHUB_TOKEN by default:
https://github.com/justincy/github-action-npm-release/blob/e237b4afa029f7982eaa6fafeace8343e902de4e/action.yml#L13

// edit: i re-added the token, so we dont have to mess with permissions...

@si458
Copy link
Collaborator

si458 commented Jan 21, 2024

@sschoen no worries! My next question was actually is the github token generated automatically or does it need to be created manually, but no worries if you have put it bk to using the my_token, it was just setup this way a few years ago when I tested it, I never realised we could use github_token until afterwards doh!

@si458 si458 merged commit 327f291 into Ylianst:master Jan 21, 2024
3 checks passed
@sschoen
Copy link
Contributor Author

sschoen commented Jan 21, 2024

@si458 the GITHUB_TOKEN is generated automatically, it is used for checkout etc., but for some actions you have to adjust the permissions
(https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants