Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch language update 1.1.21 #5862

Merged
merged 1 commit into from Feb 26, 2024
Merged

Dutch language update 1.1.21 #5862

merged 1 commit into from Feb 26, 2024

Conversation

petervanv
Copy link
Contributor

NOTE: i saw a lot off undefined strings, please review

example: [[[SERVERNAME]]] - Account Invitation\nAn account was created for you on server [[[SERVERNAME]]] ([[[SERVERURL]]]/[[[URLARGS1]]]), you can access it now with username "[[[ACCOUNTNAME]]]" and password "[[[PASSWORD]]]".\n~\nBest regards,\n~[[[USERNAME]]]

NOTE: i saw a lot off undefined strings, please review

example: [[[SERVERNAME]]] - Account Invitation\nAn account was created for you on server [[[SERVERNAME]]] ([[[SERVERURL]]]/[[[URLARGS1]]]), you can access it now with username "[[[ACCOUNTNAME]]]" and password "[[[PASSWORD]]]".\n~\nBest regards,\n~[[[USERNAME]]]
@si458
Copy link
Collaborator

si458 commented Feb 26, 2024

All looks good to me thanks!
The strings u added are all new ones I've added recently so they should be translated now correctly!

@si458 si458 merged commit 269ec02 into Ylianst:master Feb 26, 2024
3 checks passed
@petervanv
Copy link
Contributor Author

what I mean is this, a piece of text, which is not translated, but also has no function in meshcentral. the location is not filled in (xloc info)

image
image

@si458
Copy link
Collaborator

si458 commented Feb 27, 2024

yes thats prefectly fine, i spotted this while i was fixing translations,
its basically OLD text from older versions, which might of been removed in newer versions but not removed from the translate.json,
you will only see xloc IF its found the string somewhere in the txt files or handlebar files!

@petervanv
Copy link
Contributor Author

Maybe an good idea too clean it up ? if it aint nessesary (some parts, are double's)

@si458
Copy link
Collaborator

si458 commented Feb 27, 2024

@petervanv have a look then, checkout the recent translate.json and see what you can find,
i did a full extract the other day so all strings should be up to date

@petervanv
Copy link
Contributor Author

#5871

wdlut pushed a commit to wdlut/MeshCentral that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants