Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preservation of the executable rights of the files contained in a plugin #5865

Merged
merged 1 commit into from Mar 3, 2024

Conversation

wdlut
Copy link
Contributor

@wdlut wdlut commented Feb 27, 2024

On file systems that support this, the executable rights of a plug-in's files are retained.

On file systems that support this, the executable rights of a plug-in's files are retained.
@wdlut
Copy link
Contributor Author

wdlut commented Feb 27, 2024

I have not tested it on NTFS or FAT file systems. I don't expect any problems, but it would certainly be good if someone tested it before the merge.

@Ylianst Ylianst merged commit e6a71d7 into Ylianst:master Mar 3, 2024
3 checks passed
@Ylianst
Copy link
Owner

Ylianst commented Mar 3, 2024

I am going to take it and add an if statement to not do this on Windows.

Ylianst added a commit that referenced this pull request Mar 3, 2024
wdlut added a commit to wdlut/MeshCentral that referenced this pull request Mar 4, 2024
Some files were created with file rights of 0o000. It was not even possible to read them.
si458 pushed a commit that referenced this pull request Mar 5, 2024
Some files were created with file rights of 0o000. It was not even possible to read them.
wdlut added a commit to wdlut/MeshCentral that referenced this pull request Mar 19, 2024
…gin (Ylianst#5865)

On file systems that support this, the executable rights of a plug-in's files are retained.
wdlut pushed a commit to wdlut/MeshCentral that referenced this pull request Mar 19, 2024
wdlut added a commit to wdlut/MeshCentral that referenced this pull request Mar 19, 2024
Some files were created with file rights of 0o000. It was not even possible to read them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants