Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Refactor Participles to not use RegExp for direct precedence checks #1813

Closed
igorschoester opened this issue Sep 19, 2018 · 1 comment
Closed
Labels
component: regex optimization innovation Innovative issue. Relating to performance, memory or data-flow. owner: development text analysis

Comments

@igorschoester
Copy link
Member

The participles check direct precedence exceptions via a large RegExp. This caused problems on Windows in certain browsers (Chrome and possibly Opera).
Because the only interesting word in this check is the one before the participle, there is no need for a huge RegExp. See the fix for Polish.

Please apply this to the other languages too.
There are some considerations with where to put this. As the Polish was a hotfix. For exampe: I was thinking about adding the getWords results to the base Participle.

Backstory

See: Yoast/wordpress-seo#11011
Which contains the fix for Polish: #1812

@igorschoester
Copy link
Member Author

Work done in #1910

@omarreiss omarreiss removed the backlog label Oct 25, 2018
@manuelaugustin manuelaugustin added component: regex optimization innovation Innovative issue. Relating to performance, memory or data-flow. labels Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: regex optimization innovation Innovative issue. Relating to performance, memory or data-flow. owner: development text analysis
Projects
None yet
Development

No branches or pull requests

3 participants