This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Refactor Participles to not use RegExp for direct precedence checks #1813
Labels
component: regex optimization
innovation
Innovative issue. Relating to performance, memory or data-flow.
owner: development
text analysis
The participles check direct precedence exceptions via a large RegExp. This caused problems on Windows in certain browsers (Chrome and possibly Opera).
Because the only interesting word in this check is the one before the participle, there is no need for a huge RegExp. See the fix for Polish.
Please apply this to the other languages too.
There are some considerations with where to put this. As the Polish was a hotfix. For exampe: I was thinking about adding the
getWords
results to the base Participle.Backstory
See: Yoast/wordpress-seo#11011
Which contains the fix for Polish: #1812
The text was updated successfully, but these errors were encountered: