Move the overallScore CSS rules to the example pages #928

afercia · 2016-11-04T11:28:19Z

As far as I see the CSS rules and colors related to overallScore are only used on the example pages. Ideally, we shouldn't import them in the yoast-seo stylesheet to avoid they're included in the plugins where the content analysis is used.

This is part of the ongoing effort to standardise colours and improve colour contrast. See also Yoast/yoast-components#106

The text was updated successfully, but these errors were encountered:

afercia added a11y queue lingo development lingo and removed queue lingo labels Nov 4, 2016

afercia mentioned this issue Nov 4, 2016

Move the overallScore CSS out from the main stylesheet. #929

Merged

afercia assigned afercia and unassigned afercia Nov 4, 2016

afercia added needs-code-review lingo and removed development lingo labels Nov 4, 2016

afercia removed their assignment Nov 4, 2016

atimmer added needs-acceptance lingo and removed needs-code-review lingo labels Nov 7, 2016

terw-dan added acceptance lingo and removed needs-acceptance lingo labels Nov 7, 2016

terw-dan self-assigned this Nov 7, 2016

terw-dan closed this as completed in #929 Nov 7, 2016

terw-dan removed the acceptance lingo label Nov 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move the overallScore CSS rules to the example pages #928

Move the overallScore CSS rules to the example pages #928

afercia commented Nov 4, 2016

Move the overallScore CSS rules to the example pages #928

Move the overallScore CSS rules to the example pages #928

Comments

afercia commented Nov 4, 2016