Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the colors related to overallScore #6026

Closed
afercia opened this issue Nov 4, 2016 · 0 comments
Closed

Remove the colors related to overallScore #6026

afercia opened this issue Nov 4, 2016 · 0 comments
Labels
component: a11y
Milestone
3.9

Comments

@afercia
Copy link
Contributor

afercia commented Nov 4, 2016 •
edited by andizer

As a preparatory step for Yoast/yoast-components#106 we should reduce the number of colors imported that are not used. As far as I see, the styles related to .overallScore are only used for the standalone and browserified examples and should not be imported.

Going to open a related issue on YoastSEO.js.
@afercia afercia mentioned this issue Nov 4, 2016
Merged
@afercia afercia self-assigned this Nov 4, 2016
@afercia afercia mentioned this issue Nov 4, 2016
Closed
@afercia afercia removed their assignment Nov 4, 2016
@andizer andizer self-assigned this Nov 7, 2016
@andizer andizer assigned andizer and unassigned andizer Nov 7, 2016
@andizer andizer removed the acceptance label Nov 7, 2016
@andizer andizer removed their assignment Nov 8, 2016
@atimmer atimmer added this to the 3.9 milestone Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: a11y
Projects
None yet
Milestone
3.9
Development

No branches or pull requests
3 participants
@andizer @atimmer @afercia