Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Remove window reliance in assessor #1675

Merged

Conversation

nataliashitova
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

  • Removes the check of the window presence and window parameters in assessor.js. Assessor is used by the worker, who has no access to window.
  • yoastHideMarkers in only used in the term-scrapper to disable the markings in Category pages. @CarolineGeven why don't we show makings on Category pages? Also see Eye marker in the analysis doesn't highlight anything on categories or tags #1426.
  • In general, we want to implement architecture where YoastSEO.js simply provides a list of markings, while the plugin (or any other plugin that makes use of this library) decides whether or not and how to show the markings.

Test instructions

This PR can be tested by following these steps:

  • Run the analyze spam and check console that all assessments have run successfully.

Fixes #1669

@igorschoester
Copy link
Member

CR & Acceptance 👍
If there should be another action taken due to a response from Caroline, we should do that in a new issue.

@igorschoester igorschoester merged commit 9da6417 into feature/webworker Aug 7, 2018
@igorschoester igorschoester deleted the stories/1669-fix-window-reliance-markers branch August 7, 2018 11:45
@igorschoester igorschoester added this to the Web Worker milestone Aug 7, 2018
@CarolineGeven
Copy link
Contributor

This currently does not work taxonomies. We need to investigate why this doesn't. The eye markers should not be shown.

Yoast/wordpress-seo#10563
Yoast/wordpress-seo#10564

@manuelaugustin manuelaugustin added innovation Innovative issue. Relating to performance, memory or data-flow. component: webworker and removed innovation Innovative issue. Relating to performance, memory or data-flow. labels Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: webworker innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants