-
Notifications
You must be signed in to change notification settings - Fork 54
Create a TwitterImage component #50
Comments
Could your team provide us with an image that is the same as/closer to Twitter's own placeholder, or should we keep using the current one?
The Facebook preview does have some error handling: Do we want to add this feedback to the Twitter preview as well? And maybe also some specific feedback about not supported image extensions like SVG etc? |
In the design for this I'm experimenting with making the image placeholder area a drop zone, since that is kind of how the facebook one works as well. Does that work for Twitter? I know facebook doesn't show any image if it can't find a suitable one. Does Twitter still show that placeholder after you post a link with no image, or is that just to there to indicate how the template works? |
@hedgefield Twitter does use the placeholder: |
Also for the large card? Well, regardless, I think the placeholder icon is not as important as making it clear that the user should supply an image there, so I recommend following the drop zone design in https://github.com/Yoast/roadmap/issues/21 As for the error, I agree both Facebook and Twitter should display one when there is a problem with the image. As for an error about unsupported filetypes, is it even possible to upload an unsupported filetype to the media library? |
Please note that the above error message is not part of this issue. We'll deal with that in a later stage. |
What's the use of |
@johannadevos and I have pushed our work so far. What still needs to be done is:
|
As just discussed with @IreneStr, all the checks and the display of their corresponding error messages should be implemented in another issue (she already briefly mentioned this above). This means that the following part of the issue description is no longer part of the current issue: SpecificationsGeneral specs for the image
About the summary with large image, Twitter says:
And for the summary Twitter gives:
|
@andizer You say that "The large image will have a width of 506px and a height of 254px". However, this is not exactly a 2:1 ratio, which should either be 508/254 or 506/253. Where did you get these sizes from, and which size should we use in the end? EDIT: I will use 506 x 253, because I've found online that this is the size which Twitter uses. |
To create this placeholder, for blue and grey I'm using values provided by @hedgefield ( |
Closed in #131 |
The TwitterImage component will be rendered as an
img
Example of the summary with large image card.
Example of the summary card.
Properties
The type is relevant for the way we display the image. See the specifications below.
When no SRC has been given, we should show a placeholder:
Specifications
General specs for the image
About the summary with large image, Twitter says:
And for the summary Twitter gives:
Styling
The square will have a width and height of
123.422px
. The large image will have a width of 506px and a height of 253px.Parent #48
The text was updated successfully, but these errors were encountered: