Fixes the regex replacing one of the version numbers in the pluginMainFile #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nFile. Before, <%= pluginVersionConstant %> was literally matched by the regex, which is incorrect. Now, it's actually replaced by the pluginVersionConstant before the regex matches. In order to do so, the regex needed to be created using `new RegExp()`. Regexes created with // can't have dynamic content. Because we're now dealing with two types of regex formats in the config (strings and regexes with //), the task needed to be modified as well. This change also secure backwards compatibility with other plugins using this repo.
|
Acceptance ✅ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
options.regEx.Technical choices
new RegExp(). Regexes created with // can't have dynamic content. Because we're now dealing with two types of regex formats in the config (strings and regexes with //), the task needed to be modified as well. This change also secures backward compatibility with other plugins using this repo.new RegExp()need different escaping. That's where the extra slashes are coming from 😉.Test instructions
News SEO
release/11.7of News SEO.composer installandyarn installin both repos.grunt set-version --new-version=12.3-RC4in News.grunt update-versionin News.12.3-RC4, especially https://github.com/Yoast/wpseo-news/blob/trunk/wpseo-news.php#L40.wordpress-seo
release/11.7of wordpress-seo.composer installandyarn installin both repos.grunt set-version --new-version=12.3-RC4in wordpress-seo.grunt update-versionin wordpress-seo.12.3-RC4.When everything is okay, release a new version of this repo, and bump the versions in wordpress-seo and News SEO.
Fixes https://github.com/Yoast/wpseo-news/issues/516