Improve the sidebar banner links accessibility and layout #11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andizer
reviewed
Oct 18, 2018
admin/views/sidebar.php
Outdated
| @@ -6,17 +6,18 @@ | |||
| */ | |||
|
|
|||
| $wpseo_plugin_dir_url = plugin_dir_url( WPSEO_FILE ); | |||
| $new_tab_message = WPSEO_Admin_Utils::get_new_tab_message(); | |||
There was a problem hiding this comment.
Can you align the = by adding some space before it?
admin/views/sidebar.php
Outdated
| <strong><a target="_blank" rel="noopener noreferrer" href="<?php WPSEO_Shortlinker::show( 'https://yoa.st/jv' ); ?>"><?php esc_html_e( 'Yoast SEO for WordPress course', 'wordpress-seo' ); ?></a></strong><br> | ||
| <a href="<?php WPSEO_Shortlinker::show( 'https://yoa.st/jv' ); ?>" target="_blank"> | ||
| <img src="<?php echo esc_url( $wpseo_plugin_dir_url . 'images/yoast_seo_for_wp_2.svg' ); ?>" alt=""> | ||
| <strong><?php esc_html_e( 'Yoast SEO for WordPress course', 'wordpress-seo' ); ?></strong> |
There was a problem hiding this comment.
Please use sprintf for the Yoast part.
|
CR done 👍 |
|
Re: the rel noopener noreferrer thing, please see https://github.com/Yoast/wordpress-seo/issues/4605#issuecomment-425409923 New policy: only use |
|
3rd CR 👍 |
|
Acceptance 🚧
In responsive view, there are two columns: Next, there is not very pretty hybrid of one and two columns: Finally, there is one column, which is nicely centered indeed 😄: |
|
4th CR 👍 |
|
Acceptance done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Previously, each banner in the sidebar had two links: the image and the text. Although the image has an empty alt attribute
alt=""it can be still navigated to with screen readers using arrow navigation. Since there's nothing else to announce, screen readers will announce the link URL or part of it:In this case, the best option is to combine the two adjacent links in one single link following this suggested WCAG technique: https://www.w3.org/TR/WCAG20-TECHS/H2.html which also allows to reduce the number of links pointing to the same resource.
rel="noopener noreferrer"see https://github.com/Yoast/wordpress-seo/issues/4605#issuecomment-425409923WPSEO_Admin_Utils::get_new_tab_message()to get the accessible, visually hidden, message for links that open in a new browser tabThe only visual change is about the word "Free" (see below), which is now part of the link:before:after:(this can be changed but the translatable string won't be so great)Test instructions
Fixes #10338