Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes alignment of labels in publish-box #12024

Merged
merged 1 commit into from Mar 4, 2019
Merged

Changes alignment of labels in publish-box #12024

merged 1 commit into from Mar 4, 2019

Conversation

Djennez
Copy link
Member

@Djennez Djennez commented Jan 14, 2019 •
edited

Summary

This PR can be summarized in the following changelog entry:

  • [visuals] Changes the alignment of Yoast labels in the publish-box to match the default WordPress content alignment.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Create or edit a page or post and check the alignment of all labels in the publish-box.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #4929

@johannadevos
Copy link
Contributor

CR 👍
Acceptance 👍

NB: This issue and PR only concern the classic editor.

@johannadevos johannadevos reopened this Mar 4, 2019
@johannadevos johannadevos added this to the 10.1 milestone Mar 4, 2019
@johannadevos johannadevos merged commit 964d517 into trunk Mar 4, 2019
@andizer andizer deleted the 4929-fix-margin-svg branch March 6, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Djennez @johannadevos