Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the API call slightly to return less columns #15834

Merged

Conversation

jcomack
Copy link
Contributor

@jcomack jcomack commented Aug 11, 2020

Context

  • Refactors the API request slightly so we don't request unnecessary data.

Summary

This PR can be summarized in the following changelog entry:

  • Refactors request to only get the three required columns: Keyphrase, Volume and Trend.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Checkout this branch.
  • Ensure you have a valid SEMrush token present in your database before testing (see Adds OAuth for communication with SEMrush API. #15607 for more information on how to do this).
  • Navigate to a new or existing post
  • Fill in a keyphrase and click 'Get related keyphrases'.
  • Select the desired country and hit 'Change Country'
  • Ensure you get a proper response back and all the data is displayed as it should.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@jcomack jcomack added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 11, 2020
Copy link
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR OK 👍

@enricobattocchi enricobattocchi added this to the SEMrush milestone Aug 12, 2020
@enricobattocchi
Copy link
Member

Acceptance test OK 👍

@enricobattocchi enricobattocchi merged commit 7b891f2 into feature/semrush Aug 12, 2020
@enricobattocchi enricobattocchi deleted the P3-105-reduce-fields-semrush-request branch August 12, 2020 08:10
@jcomack jcomack added the innovation Innovative issue. Relating to performance, memory or data-flow. label Aug 19, 2020
@enricobattocchi enricobattocchi modified the milestones: SEMrush, 15.1 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants