Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3-111 Adds wp-api-fetch to the classic-editor asset loading configuration #15871

Merged
merged 1 commit into from Aug 17, 2020

Conversation

jcomack
Copy link
Contributor

@jcomack jcomack commented Aug 17, 2020

Context

  • Adds wp-api-fetch to the classic-editor asset loading configuration.

Summary

This PR can be summarized in the following changelog entry:

  • Adds wp-api-fetch to the classic-editor asset loading configuration.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Checkout this branch and build it.
  • Ensure you have the Classic Editor plugin installed and activated.
  • Ensure you have a valid SEMrush token.
  • Create a new post (or edit an existing one).
  • Add a keyphrase and hit the 'Get related keyphrases' button. A request should automatically be sent and succeed.
  • Alter the database from the dropdown and click 'Change Country'
  • A new request should be successfully sent.
  • Check the console and ensure there are no errors.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

[P3-111]

@jcomack jcomack added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 17, 2020
@jcomack jcomack changed the title Adds wp-api-fetch to the classic-editor asset loading configuration P3-111 Adds wp-api-fetch to the classic-editor asset loading configuration Aug 17, 2020
@JesserH
Copy link
Contributor

JesserH commented Aug 17, 2020

CR&A ✅

@JesserH JesserH merged commit be31d36 into feature/semrush Aug 17, 2020
@JesserH JesserH deleted the P3-311-add-wp-api-fetch-to-classic-editor branch August 17, 2020 12:04
@johannadevos johannadevos added this to the SEMrush milestone Aug 18, 2020
@enricobattocchi enricobattocchi modified the milestones: SEMrush, 15.1 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants