Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new css to place button next to select in SEMrushCountrySelector #16014

Merged
merged 2 commits into from Sep 8, 2020
Merged

Use new css to place button next to select in SEMrushCountrySelector #16014

merged 2 commits into from Sep 8, 2020

Conversation

karlijnbok
Copy link
Contributor

@karlijnbok karlijnbok commented Sep 7, 2020 •
edited by JesserH

Context

After the refactoring of select2 to react-select, the css had to be adjusted in order to place the button next to the select.

Summary

This PR can be summarized in the following changelog entry:

  • Places the button next to the select in the SEMrushCountrySelector component.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Make pulled feature/semrush on the monorepo and you've linked it
  • Checkout this branch and build
  • Open the related keyphrases modal
  • See the button is placed next to the select as shown in the image below

Screenshot 2020-09-07 at 15 12 56

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@karlijnbok karlijnbok added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 7, 2020
@karlijnbok karlijnbok added this to the SEMrush milestone Sep 7, 2020
jcomack
jcomack approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jcomack jcomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR done 👍

@JesserH
Copy link
Contributor

JesserH commented Sep 8, 2020

Acceptance ✅

@JesserH JesserH merged commit af8a4b4 into feature/semrush Sep 8, 2020
@JesserH JesserH deleted the P3-162-place-button-next-to-select branch September 8, 2020 08:19
@enricobattocchi enricobattocchi modified the milestones: SEMrush, 15.1 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcomack jcomack jcomack approved these changes

Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
15.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@karlijnbok @JesserH @jcomack @enricobattocchi @rolf-yoast