Check if post is not its own parent #18930
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @skallet. Can you share the step-by-step guide to reproduce your PR so that we can deep dive in? |
mmikhan
added
the
changelog: bugfix
|
Most likely fixes the https://yoast.atlassian.net/browse/IM-1867 |
|
To replicate the issue, set any post in the database Without this PR, the command will not finish. |
|
This is still an issue. |
enricobattocchi
changed the base branch from
trunk
to
feature/indexables-improvements
enricobattocchi
changed the base branch from
feature/indexables-improvements
to
trunk
Hey @skallet, I'm currently working on this issue but I cannot reproduce the endless indexing behavior: could you share some more information about your setup (WP version, plugins activated, PHP version)? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If any post is it's own parent (could be wrongly set in database) running indexing action will loop itself indefinitely.
Summary
changelog: bugfixThis PR can be summarized in the following changelog entry: