19520 improve navigation experience a11y #19615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Settings UI
by allowing screen readers to notify users when they change section.Summary
This PR can be summarized in the following changelog entry:
Settings
page.Relevant technical choices:
react-aria-live
package has been favored over@wordpress/a11y
speak
because it is implemented in a way which plays nicer with ourSettings UI
(i.e. by using React context takes care of reading things just once when it's needed).info
orwarning
boxes will give precedence to their content before announcing the section. This is foreseen behavior.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
VoiceOver
screen reader by pressing (fn)+Cmd+F5Yoast SEO
->Settings
Settings
page and verify that, at each section change, that section is being announced with the format:section name
+Settings
+Yoast SEO
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label and noted the work hours.Fixes #19520