-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard wincher connect patch #20307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/wincher-ab/wordpress-seo into add-dashboard-wincher-connect-patch
…b.com/wincher-ab/wordpress-seo into add-dashboard-wincher-connect-patch
…b.com/wincher-ab/wordpress-seo into add-dashboard-wincher-connect-patch
…er clicks on the connect button
vraja-pro
reviewed
May 15, 2023
}; | ||
|
||
WincherSEOPerformanceTable.propTypes = { | ||
isBlurred: PropTypes.object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
isBlurred: PropTypes.object, | |
isBlurred: PropTypes.bool, |
vraja-pro
reviewed
May 15, 2023
|
||
Cell.propTypes = { | ||
isBlurred: PropTypes.bool, | ||
children: PropTypes.object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
children: PropTypes.object, | |
children: PropTypes.oneOfType([ | |
PropTypes.string, | |
PropTypes.number, | |
PropTypes.object | |
]), |
…b.com/wincher-ab/wordpress-seo into add-dashboard-wincher-connect-patch
CR & AC ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
enhancement
UI change
PRs that result in a change in the UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Preliminary steps
Yoast SEO
->Integrations
Test the new widget
Dashboard
Connect with Wincher to get started
has the following format (parameters values may vary):https://yoa.st/dashboard-about-wincher?php_version=7.4&platform=wordpress&platform_version=6.2&software=premium&software_version=20.8-RC1&days_active=28&user_language=en_US
Get more insights over at Wincher
link is the following:https://app.wincher.com/login?utm_medium=plugin&utm_source=yoast&referer=yoast&partner=yoast
Test connection error
Connect
blue button and connect to your Wincher account: a popup will appearNetwork
tabNo throttling
and change it tooffline
open the developers tools and go to the
Network
tabclick on the
![Screenshot 2023-05-10 at 15 21 28](https://private-user-images.githubusercontent.com/68744851/237403797-38883a95-6aed-4094-93ff-8a23095d1346.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MDE3MTEsIm5iZiI6MTcyMDgwMTQxMSwicGF0aCI6Ii82ODc0NDg1MS8yMzc0MDM3OTctMzg4ODNhOTUtNmFlZC00MDk0LTkzZmYtOGEyMzA5NWQxMzQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDE2MjMzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI3ZTE5NzU3MzQ2ZWMzMDQ2NjUwMzRjZTBhNGU2YjFhYjEyMTUzMmY4MGViNjI5YmYwMzQwYjVjMmY4ZWVmYzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OxrbQskQ4CSl5FxSvdUlwaZOOMzAWJ6i2p-7oZNufao)
Request blocking
iconclick on
Enable Request Blocking
in the text field below add your base url (e.g.
wordpress.test
)Uncaught error
is displayedConnect
button again and verifythe following alert appears
no
Uncaught error
is displayed in the browser's consoleTest the widget's correct functioning
Restore your connection and connect with Wincher; the following alert should appear:
Add a focus keyphrase to some of your posts and track it with Wincher
With Wincher you can track the ranking position of your page in the search results based on your keyphrase(s). Read more about keyphrase tracking with Wincher
have the following format:https://yoa.st/wincher-popup?php_version=7.4&platform=wordpress&platform_version=6.2&software=premium&software_version=20.8-RC1&days_active=28&user_language=en_US
https://yoa.st/wincher-integration?php_version=7.4&platform=wordpress&platform_version=6.2&software=premium&software_version=20.8-RC1&days_active=28&user_language=en_US
Go to
Dashboard
and verify your keywords appear in theYoast SEO / Wincher: Top Keyphrases
widgetAdd some more keyphrases and track them in order to reack your keyphrase quota (it's 5 for the free tier)
Try to track another keyphrase and verify the
Upgrade your Wincher plan
link has the following format:https://yoa.st/wincher-popup-pricing?php_version=7.4&platform=wordpress&platform_version=6.2&software=premium&software_version=20.8-RC1&days_active=28&user_language=en_US
Testing backward compatibility
Yoast SEO / Wincher: Top Keyphrases
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label and noted the work hours.Fixes #