-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the opening of our document panel in WP 6.5 #21024
Merged
pls78
merged 1 commit into
trunk
from
21021-gutenberg-uncaught-typeerror-cannot-read-properties-of-undefined-reading-includes
Jan 8, 2024
Merged
Fix the opening of our document panel in WP 6.5 #21024
pls78
merged 1 commit into
trunk
from
21021-gutenberg-uncaught-typeerror-cannot-read-properties-of-undefined-reading-includes
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WP 6.5: * the `openPanels` selector moved from `core/edit-post` to `core` * the `togleEditorPanelOpened` moved from `core/edit-post` to `core/editor` The first (select) produced an error, making our integration grind to a halt. The second (dispatch) produced a deprecation warning.
igorschoester
added
the
changelog: bugfix
Needs to be included in the 'Bugfixes' category in the changelog
label
Jan 8, 2024
Pull Request Test Coverage Report for Build 3566ade0e9b53fdd486b5dd34503f6c127369a8a
💛 - Coveralls |
pls78
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR && Acc: ✅
pls78
deleted the
21021-gutenberg-uncaught-typeerror-cannot-read-properties-of-undefined-reading-includes
branch
January 8, 2024 15:03
igorschoester
added a commit
that referenced
this pull request
Jan 9, 2024
Fix for #21024 I thought it was safe for Gutenberg 17.4.1 However, it turns out that is only due to user metadata and/or local storage. On a fresh install, the same error the PR above tried to solve will occur This commit adds a fallback to prevent the error. So the functionality stays in tact. Note that just a simple check would suffice to not error too, will add safety in the next commit.
18 tasks
18 tasks
enricobattocchi
pushed a commit
that referenced
this pull request
Jan 18, 2024
Fix for #21024 I thought it was safe for Gutenberg 17.4.1 However, it turns out that is only due to user metadata and/or local storage. On a fresh install, the same error the PR above tried to solve will occur This commit adds a fallback to prevent the error. So the functionality stays in tact. Note that just a simple check would suffice to not error too, will add safety in the next commit.
enricobattocchi
added
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
and removed
changelog: bugfix
Needs to be included in the 'Bugfixes' category in the changelog
labels
Jan 19, 2024
Moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In WP 6.5:
openPanels
selector moved fromcore/edit-post
tocore
togleEditorPanelOpened
moved fromcore/edit-post
tocore/editor
The first (select) produced an error, making our integration grind to a halt.
The second (dispatch) produced a deprecation warning.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
toggleEditorPanelOpened
to determine what WP version logic to use:trunk
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
We need to test with WP 6.4 and WP 6.5 (for now Gutenberg
trunk
)Gutenberg trunk
trunk
composer install
to install PHP depsnpm install
to install JS depsnpm run dev
to buildWP 6.4
trunk
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #21021