Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation ai buttons next to seo keyphrase assessments #21348

Merged
merged 58 commits into from
May 15, 2024
Merged

Implementation ai buttons next to seo keyphrase assessments #21348

merged 58 commits into from
May 15, 2024

Commits on Apr 26, 2024

  1. Creates a draft AI button

    @Jordi-PV
    Jordi-PV committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fb3c95b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. SetHasAIFixes for the relevant assessments

    @FAMarfuaty
    FAMarfuaty committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f9d98ec View commit details
    Browse the repository at this point in the history

  2. SetHasAIFixes for the relevant assessments part 2

    @FAMarfuaty
    FAMarfuaty committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    51dfa9a View commit details
    Browse the repository at this point in the history

  3. Render the AI button when the conditions are met

    @FAMarfuaty
    FAMarfuaty committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e36d882 View commit details
    Browse the repository at this point in the history

  4. Removes AI button className props

    @Jordi-PV
    Jordi-PV committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    73da739 View commit details
    Browse the repository at this point in the history

  5. Refactors the AI Button component

    @Jordi-PV
    Jordi-PV committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8a027da View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Adds button functionalities

    @Jordi-PV
    Jordi-PV committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ce6a96c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into implement… 

    …ation-ai-buttons-next-to-seo-keyphrase-assessments
    @FAMarfuaty
    FAMarfuaty committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3828705 View commit details
    Browse the repository at this point in the history

  3. Places buttons and adds sparkles icon

    @Jordi-PV
    Jordi-PV committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6fae8be View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Grabs ui-library components with Root component

    @Jordi-PV
    Jordi-PV committed May 1, 2024
    Configuration menu
    Copy the full SHA
    17c273b View commit details
    Browse the repository at this point in the history

  2. Separate the Button base and create button for AI fixes

    @FAMarfuaty
    FAMarfuaty committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b43aba6 View commit details
    Browse the repository at this point in the history

  3. Use the yoast components for the AI button

    @FAMarfuaty
    FAMarfuaty committed May 1, 2024
    Configuration menu
    Copy the full SHA
    748e672 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'implementation-ai-buttons-next-to-seo-keyphrase-assessm… 

    …ents' of github.com:Yoast/wordpress-seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
    @FAMarfuaty
    FAMarfuaty committed May 1, 2024
    Configuration menu
    Copy the full SHA
    704bc64 View commit details
    Browse the repository at this point in the history

  5. Render sparkles icon

    @FAMarfuaty
    FAMarfuaty committed May 1, 2024
    Configuration menu
    Copy the full SHA
    160c79e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Removes ui-library button and tooltip

    @Jordi-PV
    Jordi-PV committed May 2, 2024
    Configuration menu
    Copy the full SHA
    06a7fcc View commit details
    Browse the repository at this point in the history

  2. Refactors AIFixesButton actions!

    @Jordi-PV
    Jordi-PV committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d931780 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Move the AI Assessment Fixes button to separate folder

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    38bee54 View commit details
    Browse the repository at this point in the history

  2. Add the state of the active AI Fixes button to the store

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f0ea4b0 View commit details
    Browse the repository at this point in the history

  3. Implement the background color of the AI button when pressed

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    734cadf View commit details
    Browse the repository at this point in the history

  4. Rename AI button

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b2b09f2 View commit details
    Browse the repository at this point in the history

  5. Make the Edit button styling in line with the highlighting and AI button

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    771052f View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b7368e5 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f7bd451 View commit details
    Browse the repository at this point in the history

  8. Move the styling to the button itself

    @FAMarfuaty
    FAMarfuaty committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bb62fed View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Only handle pressed button state in Premium. The pressed button state… 

    … is used to track whether there is an active AI Fixes button so we can display the button background color and the icon color differently when they are pressed. This is only relevant in Premium. In Free, this logic is irrelevant because clicking on the button will only display the Upsell modal.
    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0ea4d4a View commit details
    Browse the repository at this point in the history

  2. Adjust the grid styling

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    51ff8a2 View commit details
    Browse the repository at this point in the history

  3. Remove unused props

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fd9260d View commit details
    Browse the repository at this point in the history

  4. update tests

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    59e56e6 View commit details
    Browse the repository at this point in the history

  5. Move the logic for checking whether an assessment has AI fixes to the… 

    … `AIAssessmentFixesButton` component
    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    984f600 View commit details
    Browse the repository at this point in the history

  6. Add unit tests

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    37fec24 View commit details
    Browse the repository at this point in the history

  7. Fix missing semicolon and adjust tests

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8665d8f View commit details
    Browse the repository at this point in the history

  8. Add unit tests

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8109e6d View commit details
    Browse the repository at this point in the history

  9. Add unit tests

    @FAMarfuaty
    FAMarfuaty committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6dde924 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Add more space between the assessments

    @Jordi-PV
    Jordi-PV committed May 8, 2024
    Configuration menu
    Copy the full SHA
    abc9a77 View commit details
    Browse the repository at this point in the history

  2. Add unit tests

    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    620a5af View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/fix-assessments' of github.com:Yoast/wordpress-… 

    …seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c682c5e View commit details
    Browse the repository at this point in the history

  4. Update snapshots

    @Jordi-PV
    Jordi-PV committed May 8, 2024
    Configuration menu
    Copy the full SHA
    fb99b93 View commit details
    Browse the repository at this point in the history

  5. Add a max-width to the buttons + update snapshot

    @Jordi-PV
    Jordi-PV committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d06adb6 View commit details
    Browse the repository at this point in the history

  6. Move the logic to check the editor to inside the button component itself

    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e63917a View commit details
    Browse the repository at this point in the history

  7. Provide isPremium from the higher level component.This makes it so … 

    …that `AnalysisResult` component knows less about the specific details of AI Button
    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9bf0dab View commit details
    Browse the repository at this point in the history

  8. Merge branch 'implementation-ai-buttons-next-to-seo-keyphrase-assessm… 

    …ents' of github.com:Yoast/wordpress-seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6a9feb7 View commit details
    Browse the repository at this point in the history

  9. Update tests

    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d06ec0d View commit details
    Browse the repository at this point in the history

  10. Only relies on the state of the active AI button from the store to ke… 

    …ep track whether the button is pressed or not. This enables synchronizing pressed button styles between the AI button in the sidebar and in the metabox.
    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6127607 View commit details
    Browse the repository at this point in the history

  11. Adjust comment

    @FAMarfuaty
    FAMarfuaty committed May 8, 2024
    Configuration menu
    Copy the full SHA
    dfb131f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Martijn van der Klis <martijnvanderklis@yoast.com>
    @FAMarfuaty @mhkuu
    FAMarfuaty and mhkuu committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7c28694 View commit details
    Browse the repository at this point in the history

  2. Adapt code comment

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f379882 View commit details
    Browse the repository at this point in the history

  3. Make AIAssessmentFixesButton depends on less parameters

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0118d8d View commit details
    Browse the repository at this point in the history

  4. Update tests

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ded30ad View commit details
    Browse the repository at this point in the history

  5. If AI fixes button is active when the Highlighting button is clicked,… 

    … deactivate the AI Fixes button
    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    390adea View commit details
    Browse the repository at this point in the history

  6. If highlighting button is active when the AI Fixes button is clicked,… 

    … deactivate the highlighting button and remove the highlighting from the editor
    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    01ce12f View commit details
    Browse the repository at this point in the history

  7. mock a selector for testing

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7a35604 View commit details
    Browse the repository at this point in the history

  8. Rename a component

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    dd392ab View commit details
    Browse the repository at this point in the history

  9. Fix a typo

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    de9e65a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/fix-assessments' of github.com:Yoast/wordpress-… 

    …seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    57ac159 View commit details
    Browse the repository at this point in the history

  11. Use the same button height when clicked and not clicked and adjust th… 

    …e tests
    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    19e0d45 View commit details
    Browse the repository at this point in the history

  12. Adjust the tests

    @FAMarfuaty
    FAMarfuaty committed May 13, 2024
    Configuration menu
    Copy the full SHA
    06c422b View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Fix typos

    @FAMarfuaty
    FAMarfuaty committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ede70f0 View commit details
    Browse the repository at this point in the history

  2. Make sure that the AI button is not shown in Elementor

    @FAMarfuaty
    FAMarfuaty committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4a41337 View commit details
    Browse the repository at this point in the history