Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the blocks behaviour in the editor #21369

Merged
merged 1 commit into from
May 7, 2024

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented May 7, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where the How-To and the FAQ block could not be moved and managed in the block editor.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Add a FAQ block and a How-To block to a post/page
  • With 22.7-RC3
    • you would not be able to easily select and move the blocks in the editor: by clicking on them you would not see the bar appear at the top of it
  • With this patch
    • you should be able to see the top bar by clicking inside the block, and you should be able to move it up or down using the arrows or dragging it by hand, etc.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label May 7, 2024
@enricobattocchi enricobattocchi self-assigned this May 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build f6ecfcda8896abf628a291d599b60402abe55d41

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1434 unchanged lines in 40 files lost coverage.
  • Overall coverage decreased (-1.2%) to 51.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/structured-data-blocks/faq/block.js 0 2 0.0%
packages/js/src/structured-data-blocks/how-to/block.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/generated/assets/externals.php 1 0.0%
src/generated/assets/languages.php 1 0.0%
src/generators/breadcrumbs-generator.php 1 64.23%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.49%
admin/class-admin-editor-specific-replace-vars.php 2 85.71%
admin/endpoints/class-endpoint-statistics.php 2 0.0%
admin/formatter/class-metabox-formatter.php 2 91.77%
Totals Coverage Status
Change from base Build aa17961d17087001e6601a3491e00b3e988b2bfc: -1.2%
Covered Lines: 28351
Relevant Lines: 56272

💛 - Coveralls

@enricobattocchi
Copy link
Member Author

Merging to create a new RC ASAP

@enricobattocchi enricobattocchi merged commit de1bd3b into release/22.7 May 7, 2024
15 of 16 checks passed
@enricobattocchi enricobattocchi deleted the fix/block-handling-in-editor branch May 7, 2024 07:31
@enricobattocchi enricobattocchi added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels May 7, 2024
@mhkuu mhkuu added this to the 22.7 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants