-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add website information to the script data in Elementor #21463
Merged
enricobattocchi
merged 3 commits into
release/23.1
from
1690-231-fatal-error-shows-in-yoast-sidebar-in-upcoming-elementor-release
Jul 4, 2024
Merged
Add website information to the script data in Elementor #21463
enricobattocchi
merged 3 commits into
release/23.1
from
1690-231-fatal-error-shows-in-yoast-sidebar-in-upcoming-elementor-release
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build ff9d7066a36125afbfe94a9ba3fb07c1727dfc43Details
💛 - Coveralls |
5378051
to
d7f91f6
Compare
Pull Request Test Coverage Report for Build 51761e0da77568389bb65dfd20c006791d6f537fDetails
💛 - Coveralls |
enricobattocchi
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR & ACC ok
Pull Request Test Coverage Report for Build b2fc7d465a768ac4647d081829d3a50572bd7e29Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
wpseoScriptData
was no longer present in the Elementor editor.Relevant technical choices:
This PR is adjusting Elementor for:
The removed variables from the
wpseoScriptData.metabox
part:And the removed variables from the
wpseoScriptData
itself:Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
wpseoScriptData.metabox
and verify that the following entries are there:base_url
and is your site domaincontentLocale
and is your site locale (en_US
?)isPremium
isfalse
when you don't have Premium activeisRtl
isfalse
when you are not using a right to left localepost_edit_url
is most likely your site domain plus/wp-admin/post.php?post={id}&action=edit
search_url
is most likely your site domain plus/wp-admin/edit.php?seo_kw_filter={keyword}
siteIconUrl
is empty or the site icon URL you enteredsite_name
is your site nameuserLocale
is your user locale (en_US
?)wpseoScriptData
and verify that the following entries are there:dismissedAlerts
is (most likely) an empty arraycurrentPromotions
is (most likely) an empty arraywebinarIntroBlockEditorUrl
(though not needed due aswebinarIntroElementorUrl
is used) ishttps://yoa.st/webinar-intro-block-editor
followed by the link paramsblackFridayBlockEditorUrl
is an empty stringlinkParams
is an array with the link params including for exampleplatform: "wordpress"
pluginUrl
is the url of Yoast SEO plugin, most likely your site domain plus/wp-content/plugins/wordpress-seo
wistiaEmbedPermission
is either an empty string or 1 (as string)Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/plugins-automated-testing/issues/1690