Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard color palette and colors review #109

Merged
merged 21 commits into from Nov 18, 2016

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Nov 9, 2016

Fixes #106

Just a first pass for now, still have to create a folder where to put things (maybe create a README.md) and a colors.json but need to share the current progress to discuss a few things. I guess conflicts can be fixed later.

Things that need a decision/feedback:

  • naming conventions
  • underscore or hyphen? 😬
  • what to do about rgba greys (mainly box-shadows)
  • should the color schemes be included in the main colors file or be separated in their own file?

The base idea is to establish a general, standard, colors palette that can be used everywhere and then re-map the currently used colors to the palette-colors.

Platform-specific colors (e.g. WordPress specific link colors) shouldn't be part of the palette.

Worth noting I'm updating stuff also on YoastSEO.js on a local branch.

@afercia
Copy link
Contributor Author

afercia commented Nov 14, 2016

After some research, I'm trying grunt-scss-to-json to generate the colors.json file. See details:
https://www.npmjs.com/package/grunt-scss-to-json
https://github.com/ryanbahniuk/grunt-scss-to-json

There are more advanced tools (also a ruby gem and couple of JS modules) also for the other way around (JSON -> scss) but this one is simple and seems to work for our needs.
I'd defer to @atimmer for the final decision :)

@afercia
Copy link
Contributor Author

afercia commented Nov 16, 2016

Tested and re-tested, there are things that can be improved of course but I think it's time for a first code review and feedback :)

Side note, there are a few things to document, should they go in the readme file?

@andizer
Copy link
Contributor

andizer commented Nov 16, 2016

CR Done 👍

@terw-dan
Copy link
Member

Acceptance 👍

@terw-dan terw-dan merged commit 3733821 into develop Nov 18, 2016
@terw-dan terw-dan deleted the stories/af/106-colors-review branch November 18, 2016 10:02
@atimmer atimmer added this to the 2.1.0 milestone Nov 29, 2016
@atimmer atimmer added this to the 2.1.0 milestone Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a standardized color palette
4 participants