New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard color palette and colors review #109
Conversation
After some research, I'm trying There are more advanced tools (also a ruby gem and couple of JS modules) also for the other way around (JSON -> scss) but this one is simple and seems to work for our needs. |
Tested and re-tested, there are things that can be improved of course but I think it's time for a first code review and feedback :) Side note, there are a few things to document, should they go in the readme file? |
CR Done 👍 |
Acceptance 👍 |
Fixes #106
Just a first pass for now, still have to create a folder where to put things (maybe create a README.md) and a
colors.json
but need to share the current progress to discuss a few things. I guess conflicts can be fixed later.Things that need a decision/feedback:
The base idea is to establish a general, standard, colors palette that can be used everywhere and then re-map the currently used colors to the palette-colors.
Platform-specific colors (e.g. WordPress specific link colors) shouldn't be part of the palette.
Worth noting I'm updating stuff also on YoastSEO.js on a local branch.