Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UpsellButton component #750

Merged
merged 8 commits into from
Oct 8, 2018
Merged

Conversation

IreneStr
Copy link
Contributor

@IreneStr IreneStr commented Oct 3, 2018

Summary

This PR can be summarized in the following changelog entry:

  • Introduce UpsellButton component

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • I've implemented an example on the Buttons page in the standalone app.

@Dieterrr
Copy link
Contributor

Dieterrr commented Oct 8, 2018

CR done 👍

@Dieterrr
Copy link
Contributor

Dieterrr commented Oct 8, 2018

Acceptance done 🚧

Button works as expected in chrome, but not in firefox and safari. Here the focus style is not applied (the blue box). The active and hover styles are applied correctly though.

Also the offset seems a bit off (in all browsers): it's not completely centered. The middle is 0,78 cm from the bottom and 0,90 cm from the top. Is this intended?

See image.
upsell-button

Note: Not tested in IE/Edge.

@Dieterrr
Copy link
Contributor

Dieterrr commented Oct 8, 2018

I am merging this issue because the styling issues are minor. Created a new issue to fix these in the near future: #751

@Dieterrr Dieterrr merged commit f91b657 into develop Oct 8, 2018
@Dieterrr Dieterrr deleted the 10980-yellow-upsell-button branch October 8, 2018 15:10
@Dieterrr Dieterrr added this to the 4.14 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify all upsell buttons in yellow design
2 participants