Updated Node-sass, Grunt-sass & Jest-cli to clean up subdependencies. #840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
The original issue was to update Cryptiles to 4.1.2, but instead it has been removed as a dependency. Cryptiles was a dependency of hawk. Which was a dependency or request. Request was used by Node-sass, Grunt-sass & Jest-cli, and this resulted in 3 different versions of request in the yarn.lock file. I have updated all 3 to their latest versions which now all use the latest request(2.88) version. This has two advantages:
-only one request version is used instead of several.
-request does not use hawk (and therefore cryptiles) anymore since version 2.87 so instead of updating these dependencies we simply have removed them.
Updates Merge to 1.2.1
Updates Randomatic to 3.0.0
After updating an error was thrown in the Travis, this was solved by adding an testurl to the jest configuration as noted here: JSDom 11.12 causes SecurityError: localStorage is not available for opaque origins jestjs/jest#6766
Test instructions
This PR can be tested by following these steps:
node_modules
anddist
folder.UI changes
Fixes #837
Fixes #838
Fixes #839