Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node-sass, Grunt-sass & Jest-cli to clean up subdependencies. #840

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

Dieterrr
Copy link
Contributor

@Dieterrr Dieterrr commented Mar 5, 2019

Summary

This PR can be summarized in the following changelog entry:

  • N/A. Updated Node-sass, Grunt-sass & Jest-cli to clean up subdependencies.

Relevant technical choices:

  • The original issue was to update Cryptiles to 4.1.2, but instead it has been removed as a dependency. Cryptiles was a dependency of hawk. Which was a dependency or request. Request was used by Node-sass, Grunt-sass & Jest-cli, and this resulted in 3 different versions of request in the yarn.lock file. I have updated all 3 to their latest versions which now all use the latest request(2.88) version. This has two advantages:
    -only one request version is used instead of several.
    -request does not use hawk (and therefore cryptiles) anymore since version 2.87 so instead of updating these dependencies we simply have removed them.

  • Updates Merge to 1.2.1

  • Updates Randomatic to 3.0.0

  • After updating an error was thrown in the Travis, this was solved by adding an testurl to the jest configuration as noted here: JSDom 11.12 causes SecurityError: localStorage is not available for opaque origins jestjs/jest#6766

Test instructions

This PR can be tested by following these steps:

  • Checkout this branch.
  • Just to be sure, delete the node_modules and dist folder.
  • Rebuild all the files by running yarn and grunt.
  • All tests should pass, nothing should break. There should be no changes.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Fixes #837
Fixes #838
Fixes #839

@andizer
Copy link
Contributor

andizer commented Mar 6, 2019

Acceptance done 👍

@andizer andizer merged commit c58d7cf into develop Mar 6, 2019
@andizer andizer deleted the 839-upgrade-cryptiles-dependency branch March 6, 2019 10:20
@andizer andizer added this to the Yoast SEO 10.1 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants