test (slack): get slack view channel id in private_metadata

Yoctol · Dec 26, 2019 · 3865879 · 3865879
1 parent 092768c
commit 3865879
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 3 deletions.
diff --git a/packages/bottender/src/slack/SlackContext.ts b/packages/bottender/src/slack/SlackContext.ts
@@ -9,7 +9,7 @@ import Session from '../session/Session';
 import { PlatformContext } from '../context/PlatformContext';
 import { RequestContext } from '../types';
 
-import SlackEvent from './SlackEvent';
+import SlackEvent, { UIEvent } from './SlackEvent';
 
 type Options = {
   client: SlackOAuthClient;
@@ -373,7 +373,16 @@ export default class SlackContext extends Context<SlackOAuthClient, SlackEvent>
   _openView(options: SlackTypes.OpenViewOptions): Promise<any> {
     this._isHandled = true;
 
-    return this._client.views.open(options);
+    return this._client.views.open({
+      ...options,
+      view: {
+        ...options.view,
+        privateMetadata: JSON.stringify({
+          original: options.view.privateMetadata,
+          channelId: (this._event.rawEvent as UIEvent).channel.id,
+        }),
+      },
+    });
   }
 
   /**

diff --git a/packages/bottender/src/slack/__tests__/SlackConnector.spec.ts b/packages/bottender/src/slack/__tests__/SlackConnector.spec.ts
@@ -100,6 +100,43 @@ const interactiveMessageRequest = {
   },
 };
 
+const viewSubmissionRequest = {
+  body: {
+    type: 'view_submission',
+    team: { id: 'T02RUPSBS', domain: 'yoctolinfo' },
+    user: {
+      id: 'UCL2D708M',
+      username: 'darkbtf',
+      name: 'darkbtf',
+      team_id: 'T02RUPSBS',
+    },
+    api_app_id: 'A604E7GSJ',
+    token: 'zBoHd4fjrvVcVuN9yTmlHMKC',
+    trigger_id: '873508362498.2878808400.763026ca2acb11b3dfbcb85836d1c3d8',
+    view: {
+      id: 'VRQQ7JA4T',
+      team_id: 'T02RUPSBS',
+      type: 'modal',
+      blocks: [[Object]],
+      private_metadata: '{"channelId":"C02ELGNBH"}',
+      callback_id: '截止',
+      state: { values: {} },
+      hash: '1577340522.d58ea69f',
+      title: { type: 'plain_text', text: '確認截止？', emoji: true },
+      clear_on_close: false,
+      notify_on_close: false,
+      close: { type: 'plain_text', text: '取消', emoji: true },
+      submit: { type: 'plain_text', text: '送出 :boom:', emoji: true },
+      previous_view_id: null,
+      root_view_id: 'VRQQ7JA4T',
+      app_id: 'A604E7GSJ',
+      external_id: '',
+      app_installed_team_id: 'T02RUPSBS',
+      bot_id: 'B618CBATV',
+    },
+  },
+};
+
 const RtmMessage = {
   type: 'message',
   channel: 'G7W5WAAAA',
@@ -184,6 +221,12 @@ describe('#getUniqueSessionKey', () => {
     const channelId = connector.getUniqueSessionKey(PinAddedRequest.body);
     expect(channelId).toBe('C02ELGNBH');
   });
+
+  it("extract correct channel id from view event's private_metadata", () => {
+    const { connector } = setup();
+    const channelId = connector.getUniqueSessionKey(viewSubmissionRequest.body);
+    expect(channelId).toBe('C02ELGNBH');
+  });
 });
 
 describe('#updateSession', () => {

diff --git a/packages/bottender/src/slack/__tests__/SlackContext.spec.ts b/packages/bottender/src/slack/__tests__/SlackContext.spec.ts
@@ -483,7 +483,10 @@ describe('#views.open', () => {
 
     expect(client.views.open).toBeCalledWith({
       triggerId: '12345.98765.abcd2358fdea',
-      view: VIEW_PAYLOAD,
+      view: {
+        ...VIEW_PAYLOAD,
+        privateMetadata: '{"original":"Shh it is a secret"}',
+      },
     });
   });
 });