chore: fix codecov on ci

Yoctol · Jun 9, 2020 · 5637116 · 5637116
1 parent acfad8a
commit 5637116
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -7,7 +7,7 @@ on:
   push:
     branches:
       - master
-      - "release/**" 
+      - "release/**"
   pull_request:
     branches:
       - "**"
@@ -39,7 +39,7 @@ jobs:
           node-version: ${{ matrix.node-version }}
 
       - name: Install npm dependencies
-        run: yarn --frozen-lockfile && yarn add -W codecov
+        run: yarn --frozen-lockfile
 
       - name: Compile TypeScript files
         run: npm run compile
@@ -48,4 +48,9 @@ jobs:
         run: npm run lint
 
       - name: Run tests
-        run: npm run testonly:cov -- --no-cache --colors && ./node_modules/.bin/codecov
+        run: npm run testonly:cov -- --colors
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v1
+        with:
+          fail_ci_if_error: true
diff --git a/package.json b/package.json
@@ -24,8 +24,8 @@
     "publish": "lerna publish",
     "prepublishOnly": "yarn clean && yarn && yarn test",
     "test": "yarn compile && yarn lint && yarn testonly",
-    "testonly": "jest --detectOpenHandles",
-    "testonly:cov": "jest --coverage --runInBand --detectOpenHandles",
+    "testonly": "jest",
+    "testonly:cov": "jest --coverage",
     "testonly:watch": "jest --watch",
     "version": "cp README.md packages/bottender"
   },