Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialogflow): use for await instead of promise.all #851

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

chentsulin
Copy link
Collaborator

use for await instead of promise.all

fix #844

@chentsulin chentsulin requested a review from etrex July 29, 2020 09:09
@codecov-commenter
Copy link

Codecov Report

Merging #851 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         108      108           
  Lines        5647     5647           
  Branches     1367     1422   +55     
=======================================
  Hits         4700     4700           
  Misses        924      924           
  Partials       23       23           
Impacted Files Coverage Δ
packages/bottender-dialogflow/src/index.ts 95.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5371c14...561e49a. Read the comment docs.

@chentsulin chentsulin merged commit 5d2fedd into master Jul 29, 2020
@chentsulin chentsulin deleted the fix-dialogflow-promise-all branch July 29, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialogflow x Twilio Too Many Requests Error
3 participants