Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Kafka a TERM signal at pod stop and wait for shutdown #207

Merged
merged 5 commits into from
Nov 18, 2018
Merged

Send Kafka a TERM signal at pod stop and wait for shutdown #207

merged 5 commits into from
Nov 18, 2018

Commits on Sep 29, 2018

  1. Adds the ps command as a layer atop the existing kafka image

    @solsson
    solsson committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    c60c28d View commit details
    Browse the repository at this point in the history

  2. But the script doesn't wait for termination

    @solsson
    solsson committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    8fb8dfa View commit details
    Browse the repository at this point in the history

  3. Waits for termination before exiting hook

    @solsson
    solsson committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    af5a8bf View commit details
    Browse the repository at this point in the history

  4. Zookeeper's shutdown is identical in the kafka dist too

    @solsson
    solsson committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    e282aec View commit details
    Browse the repository at this point in the history

  5. Turns out we didn't need the ps command anyway 

    This reverts commit c60c28d.
    @solsson
    solsson committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    72ca76d View commit details
    Browse the repository at this point in the history