Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zookeeper persistence #227

Merged
merged 6 commits into from
Dec 2, 2018
Merged

Fix Zookeeper persistence #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b88b319
Mounts the parent of "datadir" AND "snapdir"
solsson Dec 1, 2018
7c589cc
The init container must have the same mount path
solsson Dec 1, 2018
8c23624
Fixes start from empty volume
solsson Dec 1, 2018
c43c6dd
Lists this fix release as it's important
solsson Dec 1, 2018
de6e737
Got OOMKilled a couple of times during maintenance with no load
solsson Dec 2, 2018
57d8200
Lists the 4.x zookeeper fix as well
solsson Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ If you begin to rely on this kafka setup we recommend you fork, for example to e

| tag | k8s ≥ | highlights |
| ----- | ------ | ---------- |
| v5.0.1 | 1.11+ | Fixes Zookeeper persistence [#227](https://github.com/Yolean/kubernetes-kafka/pull/227) |
| v5.0 | 1.11+ | Destabilize because in Docker we want Java 11 [#197](https://github.com/Yolean/kubernetes-kafka/pull/197) [#191](https://github.com/Yolean/kubernetes-kafka/pull/191) |
| v4.3.1 | 1.9+ | Critical Zookeeper persistence fix [#228](https://github.com/Yolean/kubernetes-kafka/pull/228) |
| v4.3 | 1.9+ | Adds a prpper shutdown hook [207](https://github.com/Yolean/kubernetes-kafka/pull/207) |
| v4.2 | 1.9+ | Kafka 1.0.2 and tools upgrade |
| v4.1 | 1.9+ | Kafka 1.0.1 new [default](#148) [config](#170) |
Expand Down
1 change: 1 addition & 0 deletions zookeeper/10zookeeper-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ data:
set -e
set -x

[ -d /var/lib/zookeeper/data ] || mkdir /var/lib/zookeeper/data
[ -z "$ID_OFFSET" ] && ID_OFFSET=1
export ZOOKEEPER_SERVER_ID=$((${HOSTNAME##*-} + $ID_OFFSET))
echo "${ZOOKEEPER_SERVER_ID:-1}" | tee /var/lib/zookeeper/data/myid
Expand Down
6 changes: 3 additions & 3 deletions zookeeper/50pzoo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
- name: config
mountPath: /etc/kafka
- name: data
mountPath: /var/lib/zookeeper/data
mountPath: /var/lib/zookeeper
containers:
- name: zookeeper
image: solsson/kafka:2.1.0@sha256:ac3f06d87d45c7be727863f31e79fbfdcb9c610b51ba9cf03c75a95d602f15e1
Expand All @@ -57,7 +57,7 @@ spec:
cpu: 10m
memory: 100Mi
limits:
memory: 100Mi
memory: 120Mi
readinessProbe:
exec:
command:
Expand All @@ -68,7 +68,7 @@ spec:
- name: config
mountPath: /etc/kafka
- name: data
mountPath: /var/lib/zookeeper/data
mountPath: /var/lib/zookeeper
volumes:
- name: configmap
configMap:
Expand Down
6 changes: 3 additions & 3 deletions zookeeper/51zoo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- name: config
mountPath: /etc/kafka
- name: data
mountPath: /var/lib/zookeeper/data
mountPath: /var/lib/zookeeper
containers:
- name: zookeeper
image: solsson/kafka:2.1.0@sha256:ac3f06d87d45c7be727863f31e79fbfdcb9c610b51ba9cf03c75a95d602f15e1
Expand All @@ -60,7 +60,7 @@ spec:
cpu: 10m
memory: 100Mi
limits:
memory: 100Mi
memory: 120Mi
readinessProbe:
exec:
command:
Expand All @@ -71,7 +71,7 @@ spec:
- name: config
mountPath: /etc/kafka
- name: data
mountPath: /var/lib/zookeeper/data
mountPath: /var/lib/zookeeper
volumes:
- name: configmap
configMap:
Expand Down