fix(detail_screen.dart): Add additional test and fix what happens if …

…a device for some reason has no traits
Yonomi · Jan 21, 2022 · 0286c5b · 0286c5b
1 parent 51b556a
commit 0286c5b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/traits/detail_screen.dart b/lib/traits/detail_screen.dart
@@ -57,9 +57,10 @@ class DetailScreenWidget extends StatelessWidget {
   }
 
   Widget buildContainer(List<Trait> traits) {
+    final displayTraits = (traits.isEmpty) ? [UnknownTrait('UNKNOWN')] : traits;
     final deviceWidget = DeviceWidgetBuilder()
-        .withPrimaryTrait(traits.first)
-        .withTraits(traits.skip(1).toList())
+        .withPrimaryTrait(displayTraits.first)
+        .withTraits(displayTraits.skip(1).toList())
         .build();
 
     return Container(

diff --git a/test/traits/detail_screen_test.dart b/test/traits/detail_screen_test.dart
@@ -18,6 +18,7 @@ import 'package:yonomi_device_widgets/traits/slim/lock_slim_widget.dart';
 import 'package:yonomi_device_widgets/traits/slim/power_slim_widget.dart';
 import 'package:yonomi_device_widgets/traits/slim/thermostat_slim_widget.dart';
 import 'package:yonomi_device_widgets/traits/thermostat_widget.dart';
+import 'package:yonomi_device_widgets/traits/unknown_widget.dart';
 import 'package:yonomi_device_widgets/ui/widget_style_constants.dart';
 import 'package:yonomi_platform_sdk/yonomi-sdk.dart';
 
@@ -296,6 +297,18 @@ void main() {
         WidgetStyleConstants.globalWarningColor);
   });
 
+  testWidgets(
+      'For a device with no traits, Detail screen should show an unknown trait display',
+      (WidgetTester tester) async {
+    final request = Request('', {});
+
+    await tester.pumpWidget(
+        test.createDetailScreenWidgetForTraits([], request, testedDeviceId));
+
+    expect(find.byType(UnknownWidget), findsOneWidget);
+  });
+
+
   testWidgets('Detail screen returns a multiprovider',
       (WidgetTester tester) async {
     final detailScreen =