Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenFunscripter as media source #105

Closed
Yoooi0 opened this issue Nov 30, 2022 · 2 comments
Closed

Add OpenFunscripter as media source #105

Yoooi0 opened this issue Nov 30, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Yoooi0
Copy link
Owner

Yoooi0 commented Nov 30, 2022

Api: OpenFunscripter/OFS/issues/59

@Yoooi0 Yoooi0 added enhancement New feature or request priority-medium labels Nov 30, 2022
@Yoooi0 Yoooi0 added this to the 1.24 milestone Nov 30, 2022
@Yoooi0 Yoooi0 self-assigned this Nov 30, 2022
@OpenFunscripter
Copy link

OpenFunscripter commented Dec 2, 2022

If you have suggestions on what this should look like feel free to make them.
I want to get this right the first time and not have breaking changes later down the line. 🙂

Currently I have these events.
project_change indicates that you have to clear everything after which you would receive a chain of events to reinitialize to the new project.

And this funscript_change event (which looking at the code should also be defined in the other file).
The axis mapping can only be determined by looking at the name field and checking for the conventional .roll, .sway,... extensions.
Note this event still needs an additional identifier because the name can change.
I'll just add some id value to uniquely identify the script. 🤨

There are no commands yet.

@Yoooi0
Copy link
Owner Author

Yoooi0 commented Dec 2, 2022

Yup, will make any suggestions in your issue to not mix things up 👍

I had it working very quickly, I just have to make some internal changes in MFP because the axis mapping is done very late now. Probably have to make it a global utility method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants