Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change between http and https endpoints #150

Closed
axw-pub opened this issue Dec 7, 2023 · 3 comments
Closed

Add ability to change between http and https endpoints #150

axw-pub opened this issue Dec 7, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@axw-pub
Copy link

axw-pub commented Dec 7, 2023

Describe the bug
Script repositories are hard coded to http and don't support https calls on port 443.

To Reproduce
Steps to reproduce the behavior:

  1. configure a stash or xbvr repository with ip or hostname and port 443
@Yoooi0
Copy link
Owner

Yoooi0 commented Dec 7, 2023

I dont think #151 is a correct fix as it hardcodes 443 as https port.
The EndPointBox should be converted to UriBox or something like that with ability to specify the scheme and path.
I'll try to implement it today but I have to also release 1.28/1.27.1

@Yoooi0 Yoooi0 changed the title no ssl support in script repositories No ssl support in script repositories Dec 7, 2023
@axw-pub
Copy link
Author

axw-pub commented Dec 7, 2023

Yes, it only solves the most common case. Adding a protocol drop down to the settings UI will be better, of course. I can use port 80 with a 301 redirect for now, which works fine.

@Yoooi0 Yoooi0 added enhancement New feature or request and removed bug Something isn't working labels Dec 7, 2023
@Yoooi0 Yoooi0 changed the title No ssl support in script repositories Add ability to change between http and https endpoints Dec 7, 2023
@Yoooi0 Yoooi0 added this to the 1.29 milestone Dec 7, 2023
@Yoooi0
Copy link
Owner

Yoooi0 commented Dec 12, 2023

Pushed, UriBox probably needs some styling improvements tho.
Let me know if find any issues.

@Yoooi0 Yoooi0 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants