Feature/313 - Add album details view #346

RomainNeup · 2024-02-21T18:54:22Z

Changelog

Doing the code to handle this feature request : #313

Backend Changes ⚙️

Added a new endpoint to retrieve album information:
- The endpoint now returns album details, including the first and last track listening date, tracks, and the artists.
Introduced a new endpoint to retrieve album rankings:
- The endpoint now returns information on 3 albums: one ranked better, the current one, and the one immediately after it in the ranking.
Updated the endpoint for retrieving artist statistics:
- Added functionality to retrieve the Most Listened Album of the Artist.

Frontend Changes 💻

Implemented a new album detail page:
- Includes artist context along with tracks listened.
- Displays album listened tracks.
- Shows the first and last time each track was listened to.
Added links to album pages wherever an album is mentioned across all pages.
Added a most listened album panel to the artist page.

RomainNeup · 2024-02-27T13:56:47Z

Hello @Yooooomi could you have a look please :)

quentinguidee · 2024-02-27T14:24:42Z

cfr. #348 (comment)

I think that all requests using InfosModel can use the performance boost from #348, however requests in this PR seem good for now since they are taking the same time than all other requests. I will probably try to refactor all requests at once after this PR is merged.

For the rest of this PR, the result seems pretty good! However I think there are some ESLint errors that need to be fixed before merging

Yooooomi · 2024-02-27T15:02:55Z

client/src/components/InlineAlbum/InlineAlbum.tsx

+      <Link to={`/album/${album.id}`} className={s.root}>
+        {album.name}
+      </Link>


Isn't that what InlineAlbum does?

We are in InlineAlbum, and it wasn't 🤔 Maybe I didn't got your comment

Yooooomi · 2024-02-27T15:04:10Z

client/src/components/Layout/Sider/Sider.tsx

+        onArtistClick={goToArtist}
+        onTrackClick={goToTrack}
+        onAlbumClick={goToAlbum}


Nitpick, but would be nicer to have onTrackClick, onAlbumClick, onArtistClick in this order, from small container to bigger

Done, but anyway we should get rid of this and find a cleaner way to do it. It doesn't seem very maintainable.

BTW the order (artist > track > album) is following the actual order in the search result popup.

Yooooomi · 2024-02-27T15:04:19Z

client/src/components/SiderSearch/SiderSearch.tsx

  onArtistClick,
  onTrackClick,
+  onAlbumClick,


Yooooomi · 2024-02-27T15:05:42Z

client/src/scenes/AlbumStats/AlbumStatsWrapper.tsx

+    return (
+      <FullscreenCentered>
+        <Text element="h3">
+          You never listened to this song, might be someone else registered


You never listened to this Album

Yooooomi · 2024-02-27T15:07:49Z

server/src/database/queries/artist.ts

+    { $lookup: {
+      from: 'tracks',
+      localField: 'id',
+      foreignField: 'id',
+      as: 'track'
+    }},


yes indeed is the same pattern as #348

I'll let @quentinguidee do the edit in his MR after me merged this one has mentioned in this comment : #346 (comment)

Yooooomi · 2024-02-27T15:11:31Z

I see you have the total time you listened to a specific album. Would be nice, for consistency, to have the same stat in the artist and track stat page (the times listened and total duration underneath). Nice design btw I like it :)

Yooooomi · 2024-02-27T22:56:18Z

Hello again. I realised I forgot to thank you for the job you've done. Thanks a lot man it means a lot that people get into the project to add new features!
I just pushed a new file architecture to the release 1.8.0 branch. You might want to merge this branch into yours since this merge request is going to target the 1.8.0 release branch (release/1.8.0).

EDIT: just changed the target branch for this PR, I am sorry seeing all the merge conflicts.

RomainNeup · 2024-02-28T16:25:52Z

I see you have the total time you listened to a specific album. Would be nice, for consistency, to have the same stat in the artist and track stat page (the times listened and total duration underneath). Nice design btw I like it :)

I will do it in another MR if you don't mind, as it has nothing to do with the topic of this one :)

Yooooomi · 2024-02-28T16:38:56Z

I kinda don't agree as consistency should be done as we develop new features so we don't pile up inconsistency debt.

But don't worry I'll take care of this before releasing.

RomainNeup · 2024-02-28T18:51:29Z

I kinda don't agree as consistency should be done as we develop new features so we don't pile up inconsistency debt.

But don't worry I'll take care of this before releasing.

I mean, I did it already but in another branch. So don't worry, I will just include it in this PR

RomainNeup · 2024-02-28T19:19:10Z

cfr. #348 (comment)

I think that all requests using InfosModel can use the performance boost from #348, however requests in this PR seem good for now since they are taking the same time than all other requests. I will probably try to refactor all requests at once after this PR is merged.

For the rest of this PR, the result seems pretty good! However I think there are some ESLint errors that need to be fixed before merging

Thanks 🙏
For the ES lint errors, I don't have any on my side 🤔 Do you have a log you could provide or something ?

quentinguidee · 2024-02-28T19:23:25Z

I got them when starting the dev.sh containers yesterday. However that was before the recent changes in release/1.8.0, so maybe they are not present anymore. Also I think there are also issues with eslint in release/1.8.0 so you can probably ignore them for now

Yooooomi · 2024-02-28T19:46:57Z

Yeah eslint in 1.8.0 is a mess, I've set up a stricter linting than before so don't bother about it! Thanks a lot guys for the work. I'll try to merge them by tomorrow evening or so. You guys rock

RomainNeup · 2024-02-28T20:18:55Z

Yeah eslint in 1.8.0 is a mess, I've set up a stricter linting than before so don't bother about it! Thanks a lot guys for the work. I'll try to merge them by tomorrow evening or so. You guys rock

I'm still trying to merge the branch into my branch. What a nightmare 🤯

Yooooomi · 2024-02-28T20:19:35Z

client/src/components/SiderSearch/SiderSearch.tsx

-  onArtistClick,
+export default function SideSearch({
  onTrackClick,
+  onArtistClick,
  onAlbumClick,
  inputClassname,
-}: ArtistSearchProps) {
+}: SideSearchProps) {


Typo, Sider

Yooooomi · 2024-02-28T20:21:43Z

I'm still trying to merge the branch into my branch. What a nightmare 🤯

I can take care of it if you want. Basically everything in client/ is now in apps/client

RomainNeup · 2024-02-28T20:25:09Z

Should be good but if you can check if I didn't break anything you made. Could be nice thanks 🙏

RomainNeup · 2024-02-28T20:53:46Z

Since the merge, I'm getting a Error: No private data found, cannot sign JWT 2 do you know where it does come from ?

Yooooomi · 2024-02-28T20:54:54Z

Since the merge, I'm getting a Error: No private data found, cannot sign JWT 2 do you know where it does come from ?

It seems that you did not run migrations. Do you run the project using docker and dev.sh?

Yooooomi · 2024-02-28T21:02:10Z

I am also having issues with migrations. I'll keep in touch.

Yooooomi · 2024-02-28T21:20:30Z

I fixed migrations :)

Yooooomi · 2024-02-28T21:31:52Z

I'm getting a blank page for album page, I'm trying to fix.
EDIT: It was just the Route missing.

Yooooomi · 2024-02-28T21:47:04Z

Everything works! Nice job, thanks for everything :)
Everything is ready for release 1.8.0. If you think we should wait for the time icon design before publishing it's ok otherwise we can go like this.

rneuplanche added 3 commits February 21, 2024 19:37

Create album page frontend & links to it

65d5dc7

Add new album endpoints for album details page

e4a24dc

remove trailing spaces

695a92a

RomainNeup mentioned this pull request Feb 21, 2024

feature request: album view #313

Open

rneuplanche added 3 commits February 21, 2024 20:29

Add backend album search

a17c367

Add album search to Sider searchbar

4550fdc

Add separator if multiple artists on album

a7b0740

RomainNeup mentioned this pull request Feb 27, 2024

Improve Songs/Artists/Albums query performances by ~50 #348

Merged

Yooooomi reviewed Feb 27, 2024

View reviewed changes

Yooooomi changed the base branch from master to release/1.8.0 February 27, 2024 22:56

Fix feedbacks

d7562c8

rneuplanche added 3 commits February 28, 2024 20:27

Fix prittier endOfLine on MacOS

02b8e5f

Fix

4182f7d

Merge remote-tracking branch 'upstream/release/1.8.0' into feature-313

a270848

Yooooomi reviewed Feb 28, 2024

View reviewed changes

Fix merge

bfbbebc

Yooooomi merged commit 8e9bf0d into Yooooomi:release/1.8.0 Feb 28, 2024

RomainNeup deleted the feature-313 branch March 1, 2024 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/313 - Add album details view #346

Feature/313 - Add album details view #346

RomainNeup commented Feb 21, 2024 •

edited

RomainNeup commented Feb 27, 2024

quentinguidee commented Feb 27, 2024

Yooooomi Feb 27, 2024

RomainNeup Feb 28, 2024

Yooooomi Feb 27, 2024

RomainNeup Feb 28, 2024

Yooooomi Feb 27, 2024

Yooooomi Feb 27, 2024

Yooooomi Feb 27, 2024

RomainNeup Feb 28, 2024

Yooooomi commented Feb 27, 2024

Yooooomi commented Feb 27, 2024 •

edited

RomainNeup commented Feb 28, 2024

Yooooomi commented Feb 28, 2024 •

edited

RomainNeup commented Feb 28, 2024

RomainNeup commented Feb 28, 2024

quentinguidee commented Feb 28, 2024 •

edited

Yooooomi commented Feb 28, 2024 •

edited

RomainNeup commented Feb 28, 2024

Yooooomi Feb 28, 2024

Yooooomi commented Feb 28, 2024 •

edited

RomainNeup commented Feb 28, 2024

RomainNeup commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024 •

edited

Yooooomi commented Feb 28, 2024

Feature/313 - Add album details view #346

Feature/313 - Add album details view #346

Conversation

RomainNeup commented Feb 21, 2024 • edited

Changelog

Backend Changes ⚙️

Frontend Changes 💻

RomainNeup commented Feb 27, 2024

quentinguidee commented Feb 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yooooomi commented Feb 27, 2024

Yooooomi commented Feb 27, 2024 • edited

RomainNeup commented Feb 28, 2024

Yooooomi commented Feb 28, 2024 • edited

RomainNeup commented Feb 28, 2024

RomainNeup commented Feb 28, 2024

quentinguidee commented Feb 28, 2024 • edited

Yooooomi commented Feb 28, 2024 • edited

RomainNeup commented Feb 28, 2024

Choose a reason for hiding this comment

Yooooomi commented Feb 28, 2024 • edited

RomainNeup commented Feb 28, 2024

RomainNeup commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024

Yooooomi commented Feb 28, 2024 • edited

Yooooomi commented Feb 28, 2024

RomainNeup commented Feb 21, 2024 •

edited

Yooooomi commented Feb 27, 2024 •

edited

Yooooomi commented Feb 28, 2024 •

edited

quentinguidee commented Feb 28, 2024 •

edited

Yooooomi commented Feb 28, 2024 •

edited

Yooooomi commented Feb 28, 2024 •

edited

Yooooomi commented Feb 28, 2024 •

edited