New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added helper to get single gene normalized rates #580
Added helper to get single gene normalized rates #580
Conversation
It seems like this could all be options in the already existing |
Hi Valentine, Thanks for contributing. Indeed, I think we could refactor this to be a modification of get_sample_scale by adding some options to it! Best, |
Sure! I'll take a stab at making a refactored version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @vals. Please let me know what you think.
It seems the tool |
@vals sorry I missed this. I'll give a review now, but perhaps upgrading your black will help fix this. |
@vals, we'd like to get 0.6.2 out soon. If you're able to address these items soon we could include this. No rush, but just wanted to keep you in the loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure what's happening with CI. Might have to merge into a temporary branch and make a new PR. Also I'll add a test for this.
I made a helper method for
Posterior
which lets you get expression rates at a normalized library size for a single gene of interest. This way you can e.g. plot the expression of a particular gene without needing to store the 'imputed' matrix for the entire dataset in RAM.