convenience wrapper of torch.set_num_threads #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
- Coverage 89.72% 89.69% -0.04%
==========================================
Files 87 87
Lines 6182 6190 +8
==========================================
+ Hits 5547 5552 +5
- Misses 635 638 +3
Continue to review full report at Codecov.
|
adamgayoso
requested changes
Mar 11, 2021
scvi/_settings.py
Outdated
Comment on lines
124
to
127
| def set_num_threads(self, num: int): | ||
| """Sets number of threads torch will use to `num`.""" | ||
| torch.set_num_threads(num) | ||
|
|
There was a problem hiding this comment.
num_threads needs to be a property with a setter, the setter runs num threads, you can default the property to return None?
adamgayoso
requested changes
Mar 11, 2021
adamgayoso
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1000